| 1 |
Hi Matt, |
| 2 |
|
| 3 |
I see that you're one of the maintainers of the alpha architecture in |
| 4 |
the Linux kernel. Compiling with CONFIG_ALPHA_TSUNAMI=y has been broken |
| 5 |
for a while, and the fix seems simple. Is there any chance you can sign |
| 6 |
off on the patch I proposed on Feb 18? Or is there a better solution |
| 7 |
for this build problem? |
| 8 |
|
| 9 |
|
| 10 |
On Sat, Feb 18, 2012 at 05:39:57PM -0500, Jim Faulkner wrote: |
| 11 |
> On Sun, Feb 19, 2012 at 11:29:34AM +1300, Michael Cree wrote: |
| 12 |
> > > |
| 13 |
> > > +#include <linux/module.h> |
| 14 |
> > |
| 15 |
> > Wouldn't <linux/exports.h> be better? I seem to recall that this was a |
| 16 |
> > problem with EXPORT_SYMBOL not being defined and I see my own personal |
| 17 |
> > fix (which I had completely forgotten to send upstream) was to include |
| 18 |
> > <linux/exports.h> |
| 19 |
> |
| 20 |
> core_marvel.c and core_titan.c both include <linux/module.h> in the |
| 21 |
> mainline kernel, which is why I thought it was the appropriate fix for |
| 22 |
> core_tsunami.c. |
| 23 |
> |
Archives