Gentoo Archives: gentoo-alt

From: Fabian Groffen <grobian@g.o>
To: gentoo-alt@l.g.o
Subject: Re: [gentoo-alt] AIX: libiconv issues still ?
Date: Fri, 04 May 2007 20:05:41
Message-Id: 20070504200529.GI885@gentoo.org
In Reply to: Re: [gentoo-alt] AIX: libiconv issues still ? by Michael Haubenwallner
On 23-04-2007 10:43:06 +0200, Michael Haubenwallner wrote:
> On Fri, 2007-04-20 at 17:53 +0200, Fabian Groffen wrote: > > On 20-04-2007 10:43:56 -0500, Marshall McMullen wrote: > > > WOO HOO , that worked! You ROCK Haubi ! > > > > So wait, hold on. Where do I have to apply which patch now? > > > > to portage (bin/misc-functions.sh), the attached one.
> --- bin/misc-functions.sh.orig 2007-04-04 17:49:18.003057000 +0200 > +++ bin/misc-functions.sh 2007-04-04 17:58:24.466904000 +0200 > @@ -312,6 +312,9 @@ > abort="no" > for a in "${ED}"usr/lib*/*.a ; do > s=${a%.a}.so > + if [[ -L ${s} ]] ; then > + s=${D}$(readlink "${s}") || s=${a%.a}.so
What's the || for? (A trail of previous && || usage?)
> + fi > if [[ ! -e ${s} ]] ; then > s=${s%usr/*}${s##*/usr/} > if [[ -e ${s} ]] ; then
I think this patch isn't safe. What if a relative link is given? Apparently an invalid symlink makes -e (existence test) fail? -- Fabian Groffen Gentoo on a different level -- gentoo-alt@g.o mailing list

Replies

Subject Author
Re: [gentoo-alt] AIX: libiconv issues still ? Michael Haubenwallner <michael.haubenwallner@×××××××.at>