1 |
On Thu, 2007-04-19 at 16:33 +0200, Fabrizio Listello wrote: |
2 |
> I've found another similar (?) shell problem during compiling of MPlayer. |
3 |
> [...] |
4 |
> >>> Compiling source in |
5 |
> /opt/gentoo/var/tmp/portage/media-video/mplayer-1.0_rc1-r2/work/MPlayer-1.0rc1 |
6 |
> ... |
7 |
> * QA Notice: USE Flag 'ppc64' not in IUSE for media-video/mplayer-1.0_rc1-r2 |
8 |
> Detected operating system: SunOS |
9 |
> Detected host architecture: i386 |
10 |
> Checking for i386-pc-solaris2.11-gcc version ... 4.1.2, ok |
11 |
> [...] |
12 |
> Checking for tga ... no |
13 |
> Checking for DirectFB ... ./configure: syntax error at line 3756: |
14 |
> `_dfb_version=$' unexpected |
15 |
> |
16 |
> [...] |
17 |
> |
18 |
> And this is the line with the problem: |
19 |
> 3756: _dfb_version=$(dfb_version $_dfb_major $_dfb_minor $_dfb_micro) |
20 |
> |
21 |
> The mplayer configure script uses /bin/sh which is the Bourne shell |
22 |
> and not Bourne-again shell. |
23 |
|
24 |
It is defined that configure-scripts need to work with bourne shells |
25 |
(/bin/sh). And "$(foo)" is bash (or ksh) style. |
26 |
|
27 |
Replacing line 3756 like this should work: |
28 |
|
29 |
- _dfb_version=$(dfb_version $_dfb_major $_dfb_minor $_dfb_micro) |
30 |
+ _dfb_version=`dfb_version $_dfb_major $_dfb_minor $_dfb_micro` |
31 |
|
32 |
> |
33 |
> |
34 |
> I'm proposing to patch the "configure" script with a single line in |
35 |
> ebuild unpack function: |
36 |
|
37 |
This is the quick&dirty hack, the goal should be to fix the origin of |
38 |
that line: |
39 |
*) maybe configure.in, then it should be reported upstream, |
40 |
*) maybe a patch already in the tree, then fix that patch. |
41 |
|
42 |
> |
43 |
> --- mplayer-1.0_rc1-r2.ebuild.mio 2007-04-19 16:33:28.545169753 +0200 |
44 |
> +++ mplayer-1.0_rc1-r2.ebuild 2007-04-19 16:32:20.262831061 +0200 |
45 |
> @@ -131,5 +131,5 @@ |
46 |
> SLOT="0" |
47 |
> LICENSE="GPL-2" |
48 |
> -KEYWORDS="~amd64 ~ia64 ~ppc-macos ~x86 ~x86-macos ~x86-solaris" |
49 |
> +KEYWORDS="~amd64 ~ia64 ~ppc-macos ~x86 ~x86-macos" |
50 |
> |
51 |
> pkg_setup() { |
52 |
> @@ -204,8 +204,4 @@ |
53 |
> sed -i -e "s:-O4:-O4 -D__STDC_LIMIT_MACROS:" configure |
54 |
> |
55 |
> - # Solaris /bin/sh fix |
56 |
> - if [[ ${CHOST} == *-solaris* ]] ; then |
57 |
> - sed -e "s:^#!.*/bin/sh:#!${EPREFIX}/bin/sh:" -i configure |
58 |
> - fi |
59 |
|
60 |
Maybe setting CONFIG_SHELL=${EPREFIX}/bin/bash could work too ? |
61 |
|
62 |
/haubi/ |
63 |
> } |
64 |
> |
65 |
> |
66 |
> On 4/14/07, Fabian Groffen <grobian@g.o> wrote: |
67 |
> > On 12-04-2007 13:15:08 +0200, Michael Haubenwallner wrote: |
68 |
> > > On Thu, 2007-04-12 at 12:39 +0200, Fabian Groffen wrote: |
69 |
> > > > On 12-04-2007 10:25:46 +0200, Michael Haubenwallner wrote: |
70 |
> > > > > Hi, |
71 |
> > > > > |
72 |
> > > > > with solaris /bin/sh, this does not work: |
73 |
> > > > > echo 1 | grep -E ^[[:digit:]]+$ |
74 |
> > > > |
75 |
> > > > I guess this is Solaris <10? |
76 |
> > > |
77 |
> > > exactly, Thanks. |
78 |
> > |
79 |
> > I fixed this one or two days ago. If it's not in the latest portage, |
80 |
> > then it'll be in the portage that I'll roll out today. |
81 |
> > |
82 |
> > -- |
83 |
> > Fabian Groffen |
84 |
> > Gentoo on a different level |
85 |
> > |
86 |
> > -- |
87 |
> > gentoo-alt@g.o mailing list |
88 |
> > |
89 |
> > |
90 |
> |
91 |
> |
92 |
> -- |
93 |
> |
94 |
> FList |
95 |
|
96 |
-- |
97 |
gentoo-alt@g.o mailing list |