Gentoo Archives: gentoo-alt

From: Burcin Erocal <burcin@××××××.org>
To: gentoo-alt@l.g.o
Subject: Re: [gentoo-alt] portage bug ?
Date: Wed, 31 Aug 2011 09:43:36
Message-Id: 20110831114527.6550094b@carl.erocal.org
In Reply to: Re: [gentoo-alt] portage bug ? by Fabian Groffen
On Mon, 29 Aug 2011 21:05:20 +0200
Fabian Groffen <grobian@g.o> wrote:

> On 29-08-2011 11:42:03 +0200, Fabian Groffen wrote: > > On 29-08-2011 11:30:46 +0200, Burcin Erocal wrote: > > > > "--dir-file=%s/dir %s/%s" % (EPREFIX, inforoot, inforoot, > > > > x))[1] TypeError: not all arguments converted during string > > > > formatting > > > > > > I also ran into this last week. The following patch fixes the > > > problem for me. It seems to be introduced in the prefix version > > > of portage. > > > > > > > Thanks, there was a bug about it, I now see there is a ) missing. > > I'll apply your patch soon. > > I've been looking at default, and didn't find extra parenthesis there, > so I tried the following. Does that work for you? > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commitdiff;h=749ef8e20137bede1a9824448b2676224b06f71b;hp=5b6156b085ab5ae518fa6c4ed9b2e2c5b75fd184 > or > http://prefix.gentooexperimental.org:8000/portage-prefix/rev/4e2a4854863a
I didn't have time to test the patch myself, since we already have a report of it not working, here is a justification for my patch... AFAICT, the original error message indicates that more arguments are provided to % than there are place holders in the string. The + operator has lower precedence than %, so the string is not concatenated with the part on the previous line. Note that the string in the error message has 3 place holders only, the fourth should come from the line above. I added parenthesis around the string addition to fix the precedence problem. Cheers, Burcin

Replies

Subject Author
Re: [gentoo-alt] portage bug ? Fabian Groffen <grobian@g.o>