1 |
On 10/06/11 10:15, Michael Haubenwallner wrote: |
2 |
> Hi Alan, |
3 |
> |
4 |
> On 10/06/2011 12:33 AM, Alan Hourihane wrote: |
5 |
>> On 10/05/11 22:39, Jonathan Callen wrote: |
6 |
>>> On 10/05/2011 03:01 PM, Alan Hourihane wrote: |
7 |
>>>> On 10/04/11 11:24, Alan Hourihane wrote: |
8 |
>>>>> On 10/04/11 11:21, Alan Hourihane wrote: |
9 |
>>>>>> On 08/14/11 19:05, Alan Hourihane wrote: |
10 |
>>>>>>> On 08/14/11 11:40, Fabian Groffen wrote: |
11 |
>>>>>>>> On 07-07-2011 15:42:40 +0100, Alan Hourihane wrote: |
12 |
>>>>>>>>> Hi all, |
13 |
>>>>>>>>> |
14 |
>>>>>>>>> Can someone replace the link the cmake eclass that says |
15 |
>>>>>>>>> .... |
16 |
>>>>>>>>> |
17 |
>>>>>>>>> if use prefix; then |
18 |
>>>>>>>>> |
19 |
>>>>>>>>> to |
20 |
>>>>>>>>> |
21 |
>>>>>>>>> if use prefix && ! EPREFIX=; then |
22 |
>>>>> if use prefix && "${EPREFIX}" != ""; then |
23 |
>>>>> |
24 |
>>>>> The above is better. Can this be committed ? |
25 |
>>>>> |
26 |
>>>> Actually this works for me..... |
27 |
>>>> if use prefix && ! ${EPREFIX}; then |
28 |
>>> I hope you meant: |
29 |
>>> |
30 |
>>> if use prefix && ! [[ ${EPREFIX} ]]; then |
31 |
> Reading the different variants (without reading the cmake.eclass), |
32 |
> these variants do give different results. |
33 |
> |
34 |
> Probably, you do want to fire that 'if' when "EPREFIX is not empty", right? |
35 |
|
36 |
Right. |
37 |
|
38 |
> Actually, the last one (as reported in [1]) does fire "when EPREFIX is empty". |
39 |
> |
40 |
> So you probably want: |
41 |
> |
42 |
> - if use prefix; then |
43 |
> + if use prefix && [[ ${EPREFIX} ]]; then |
44 |
> |
45 |
> So - have you actually tried your reported variant? |
46 |
|
47 |
It originally started out with |
48 |
|
49 |
if use prefix && ! $EPREFIX=; then |
50 |
|
51 |
which seemed to do the trick, but obviously hadn't tested it. |
52 |
|
53 |
I'll re-test with your line above. |
54 |
|
55 |
> <pointless optimization> |
56 |
> Given that EPREFIX is set with 'use prefix' only, it could also read: |
57 |
> |
58 |
> - if use prefix; then |
59 |
> + if [[ ${EPREFIX} ]]; then |
60 |
> </pointless optimization> |
61 |
> |
62 |
|
63 |
Shall I try this instead then ? |
64 |
|
65 |
> OTOH: Do we support non-empty EPREFIX on FreeMiNT? |
66 |
> |
67 |
|
68 |
Yes. |
69 |
|
70 |
Alan. |