Gentoo Archives: gentoo-alt

From: Burcin Erocal <burcin@××××××.org>
To: gentoo-alt@l.g.o
Subject: Re: [gentoo-alt] permission test
Date: Tue, 18 Oct 2011 18:34:35
Message-Id: 20111018203412.76f5dbd0@carl.erocal.org
In Reply to: Re: [gentoo-alt] permission test by Fabian Groffen
Hi Fabian,

Thanks for the quick response.

On Tue, 18 Oct 2011 20:13:14 +0200
Fabian Groffen <grobian@g.o> wrote:

> On 18-10-2011 20:10:24 +0200, Burcin Erocal wrote: > > Attached trivial patch puts this check in an if statement depending > > on an environment variable QA_SKIP_WRITABLE. Setting this in > > make.conf makes prefix usable again. > > > diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh > > --- a/bin/misc-functions.sh > > +++ b/bin/misc-functions.sh > > @@ -168,6 +168,7 @@ > > fi > > > > # Now we look for all world writable files. > > + if [ "${QA_SKIP_WRITABLE-unset}" == unset ] ; then > > local i > > for i in $(find "${D}/" -type f -perm -2); do > > How would this work, if you changed the D into ED here? Checking > files outside of our control is indeed not really useful.
In that context, printing $D gives $PORTAGE_TMP/$CATEGORY/$P/image in the prefix. Since these are the new files introduced by the ebuild, I don't think we need to change that line. Note that this is already in the portage sources and I didn't touch it. :) Cheers, Burcin

Replies

Subject Author
Re: [gentoo-alt] permission test Fabian Groffen <grobian@g.o>