Re: [gentoo-alt] Any interest in sandbox on (open)solaris?

[C. Bergström]

Mike Frysinger wrote:
> On Tuesday 18 November 2008 17:33:55 C. Bergström wrote:
>
>> Fabian Groffen wrote:
>>
>>> On 18-11-2008 20:48:58 +0100, "C. Bergström" wrote:
>>>
>>>> If anyone is interested in sandbox working correctly on (open)solaris
>>>> please give both feedback and any technical details which may help. I'm
>>>> looking into how LD_PRELOAD works and any difference between
>>>> linux/solaris.  I tried to compile the alpha version, but didn't read
>>>> the code at all.
>>>>
>>> Yes, very interesting in having it running.  Please look at the current
>>> git sources, which had a recent spike of activity:
>>> http://git.overlays.gentoo.org/gitweb/?p=proj/sandbox.git;a=summary
>>>
>> Ok. I pulled the latest git work and with a few really dirty hacks to
>> the configure it was rolling..
>>
>> (Here's some of the output of the failure.. I haven't looked at it at all)
>> http://rafb.net/p/fELaK960.html
>>
>
> very first rule if you want to make this work: never post log files to an
> external site, especially one like rafb.net where things expire quickly.
>
> you're hitting an issue with what i hinted at earlier ... symbol versioning.
> iirc, the symbol version script (for our purposes) should be the same between
> the GNU linker and the Solaris linker.  but how you tell the linker about the
> version script obviously wont be the same.  you'll have to figure that out and
> we can add a configure test to detect the linker in use.
>
> all those warnings are kind of painful too ... probably have to find a
> autoconf macro for detecting attribute support in the compiler.  iirc, glibc
> tends to use __GNUC__ type CPP macros though.
>
> the memory (xmalloc, etc...) arent too surprising.  that's a bit of a mess atm
> and i intend to clean that stuff up anyways ...
>
> the symbols.h errors are odd.  probably a CPP difference between your compiler
> and the GNU C compiler.
>
> you should figure out how solaris forces C++ exception handling.  clearly it
> doesnt use the same flag as GCC: -fexceptions.  that'll have to be turned into
> a configure compiler test as well.
>
> g'luck ... seems you got your work cut out for you :p
>
Aww.. not even a little optimism? :P

I could cheat and use cw which converts gcc flags over to sun cc flags 
and vice versa, but that's cheating.. 

Down to the nitty gritty to get this to build.. Which is goal #1 to just 
get the thing to build..

For "the symbols.h errors are odd. probably a CPP difference between 
your compiler and the GNU C compiler." did you mean

"../libsbutil/sbutil.h", line 102: warning: attribute parameter "__printf__" is undefined

that's just a warning, but yeah. I can guess what's needed to make it go 
away..
------

Undefined symbols..

__check_arg_fd                      ../libsbutil/.libs/libsbutil.a(dynbuf.o)
__check_arg_ptr                     ../libsbutil/.libs/libsbutil.a(string.o)
__check_arg_str                     ../libsbutil/.libs/libsbutil.a(string.o)

check_strv                          ../libsbutil/.libs/libsbutil.a(file.o)
check_ptr                           
../libsbutil/.libs/libsbutil.a(sb_open.o)

__xrealloc                          sandbox-environ.o
__xstrndup                          sandbox-environ.o
check_str                           sandbox-environ.o
__xcalloc                           sandbox-environ.o
__xmalloc                           sandbox-environ.o


cc options used to build

 cc -DHAVE_CONFIG_H -I. -I.. -I.. -I./include "-DETCDIR=\"/usr/etc\"" 
"-DLIBSANDBOX_PATH=\"/usr/lib/amd64\"" 
"-DSANDBOX_BASHRC_PATH=\"/usr/share/sandbox\"" -DPIC -fPIC -D_GNU_SOURCE 
-D_REENTRANT -i -xO4 -xspace -xstrconst -fast -xregs=no%frameptr -m64 
-KPIC -c src/string.c  -KPIC -DPIC -o .libs/string.o

cc -DHAVE_CONFIG_H -I. -I.. -I.. -I./include "-DETCDIR=\"/usr/etc\"" 
"-DLIBSANDBOX_PATH=\"/usr/lib/amd64\"" 
"-DSANDBOX_BASHRC_PATH=\"/usr/share/sandbox\"" -DPIC -fPIC -D_GNU_SOURCE 
-D_REENTRANT -i -xO4 -xspace -xstrconst -fast -xregs=no%frameptr -m64 
-KPIC -c src/dynbuf.c  -KPIC -DPIC -o .libs/dynbuf.o

cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../libsbutil -I../libsbutil/include 
-DPIC -fPIC -D_GNU_SOURCE -D_REENTRANT -DOUTSIDE_LIBSANDBOX -i -xO4 
-xspace -xstrconst -fast -xregs=no%frameptr -m64 -KPIC -c -o 
sandbox-environ.o environ.c 
--

processed output to see what's really happening..  (Here's the fun part 
to play guess what makes sun cc happy :P )  I'll see if I can figure 
this out tomorrow/soon..  I'll have to consult the CC manual for the 
-fexception equivalent..

CC manual for the curious..
http://docs.sun.com/source/820-4180/man1/CC.1.html

cc manual
http://docs.sun.com/source/820-4180/man1/cc.1.html

--------------

I'm past my productive hour, but for anyone who wants to play what makes 
sun cc unhappy.. here's the offending lines of code

7284 inline  _Bool __check_arg_fd (int fd, const char *file, const char 
*func,   size_t line);

7962   if (! __check_arg_fd ( fd , "src/dynbuf.c" , __func__ , 182 ))
8113   if (! __check_arg_fd ( fd , "src/dynbuf.c" , __func__ , 333 ))
--

7278 inline  _Bool __check_arg_ptr (const void *ptr, const char *file, 
const char *func,  size_t line);

7825   if (! __check_arg_ptr ( str , "src/string.c" , __func__ , 45 ))

--
7280 inline  _Bool __check_arg_str (const char *str, const char *file, 
const char *func, size_t line);

7800   if ((! __check_arg_str ( pathname1 , "src/string.c" , __func__ , 
20 )) || (! __check_arg_str ( pathname2 , "src/string.c     " , __func__ 
, 20 )))
7846   if (! __check_arg_str ( path , "src/string.c" , __func__ , 66 ))
----

7308 inline void *__xrealloc (void *ptr, size_t size, const char *file, 
const char *func, size_t line);
7313 inline char *__xstrndup (const char *str, size_t size, const char 
*file, const char *func, size_t line);
7280 inline  _Bool check_str (const char *str);



8103          do { char * * _tmp_p ; int _i = 0 ; if ( ! check_str ( 
tmp_string ) ) { goto error ; } while ( ( 0L != ( * envp )      ) && ( 
0L != ( * envp ) [ _i ] ) ) { _i ++ ; } _tmp_p = __xrealloc ( ( * envp ) 
, sizeof ( char * ) * ( _i + 2 ) , "envir     on.c" , __func__ , 235 ) ; 
if ( 0L == _tmp_p ) { goto error ; } ( * envp ) = _tmp_p ; ( * envp ) [ 
_i ] = tmp_string ; ( *      envp ) [ _i + 1 ] = 0L ; } while ( 0 );

8205                          do { char * _tmp_str ; char * * _tmp_p ; 
int _i = 0 ; if ( ! check_str ( ( * env_ptr ) ) ) { goto      error ; } 
while ( ( 0L != new_environ ) && ( 0L != new_environ [ _i ] ) ) { _i ++ 
; } _tmp_p = __xrealloc ( new_environ ,      sizeof ( char * ) * ( _i + 
2 ) , "environ.c" , __func__ , 342 ) ; if ( 0L == _tmp_p ) { goto error 
; } new_environ = _tmp     _p ; _tmp_str = __xstrndup ( ( * env_ptr ) , 
strlen ( ( * env_ptr ) ) , "environ.c" , __func__ , 342 ) ; if ( 0L == 
_tmp_s     tr ) { goto error ; } new_environ [ _i ] = _tmp_str ; 
new_environ [ _i + 1 ] = 0L ; } while ( 0 );

------------

7304 inline void *__xcalloc (size_t nmemb, size_t size, const char 
*file, const char *func, size_t line);
8144                 ld_preload_envvar =  __xcalloc ( strlen ( 
orig_ld_preload_envvar ) + strlen ( sandbox_info -> sandbox_lib      ) + 
2 , sizeof ( char ) , "environ.c" , __func__ , 276 ) ;
---------

7306 inline void *__xmalloc (size_t size, const char *file, const char 
*func, size_t line);
8096         tmp_string =  __xmalloc ( ( strlen ( name ) + strlen ( val 
) + 2 ) * sizeof ( char ) , "environ.c" , __func__ , 22     8 );