| 1 |
On 23-04-2007 10:43:06 +0200, Michael Haubenwallner wrote: |
| 2 |
> On Fri, 2007-04-20 at 17:53 +0200, Fabian Groffen wrote: |
| 3 |
> > On 20-04-2007 10:43:56 -0500, Marshall McMullen wrote: |
| 4 |
> > > WOO HOO , that worked! You ROCK Haubi ! |
| 5 |
> > |
| 6 |
> > So wait, hold on. Where do I have to apply which patch now? |
| 7 |
> > |
| 8 |
> |
| 9 |
> to portage (bin/misc-functions.sh), the attached one. |
| 10 |
|
| 11 |
> --- bin/misc-functions.sh.orig 2007-04-04 17:49:18.003057000 +0200 |
| 12 |
> +++ bin/misc-functions.sh 2007-04-04 17:58:24.466904000 +0200 |
| 13 |
> @@ -312,6 +312,9 @@ |
| 14 |
> abort="no" |
| 15 |
> for a in "${ED}"usr/lib*/*.a ; do |
| 16 |
> s=${a%.a}.so |
| 17 |
> + if [[ -L ${s} ]] ; then |
| 18 |
> + s=${D}$(readlink "${s}") || s=${a%.a}.so |
| 19 |
|
| 20 |
What's the || for? (A trail of previous && || usage?) |
| 21 |
|
| 22 |
> + fi |
| 23 |
> if [[ ! -e ${s} ]] ; then |
| 24 |
> s=${s%usr/*}${s##*/usr/} |
| 25 |
> if [[ -e ${s} ]] ; then |
| 26 |
|
| 27 |
I think this patch isn't safe. What if a relative link is given? |
| 28 |
|
| 29 |
Apparently an invalid symlink makes -e (existence test) fail? |
| 30 |
|
| 31 |
|
| 32 |
-- |
| 33 |
Fabian Groffen |
| 34 |
Gentoo on a different level |
| 35 |
|
| 36 |
-- |
| 37 |
gentoo-alt@g.o mailing list |
Archives