Applied, thanks!

On 26-04-2007 09:47:28 +0200, Michael Haubenwallner wrote:
> Hi,
> 
> after some investigation, this has nothing to do with '-g', but with
> '-O', or more precise, with missing '-O'.
> 
> One thing is that the ebuild removes the openssl-default CFLAG '-O3'
> with some sed-magic.
> 
> Now when the user did not tweak CFLAGS/CXXFLAGS yet, thus having them
> empty, we end up building shared-lib (uses -fPIC) without any
> optimization flag.
> Unfortunately, this is the only situation where it doesn't work [1].
> [1] http://gcc.gnu.org/ml/gcc-help/2007-04/msg00200.html
> 
> Attached patch adds '-O1' if we have '-O0' or no '-O' at all.
> Should we keep '-O3' in this case ?
> But when user wants '-g', '-O3' might be ways less useful than '-O1'.
> 
> With this patch, openssl-0.9.8e can be unmasked for x86-linux.
> 
> /haubi/
> 
> On Thu, 2007-04-12 at 15:58 +0200, Michael Haubenwallner wrote:
> > Hi,
> > 
> > I've hit this compile error on x86-linux with dev-libs/openssl-0.9.8e:
> > http://www.mail-archive.com/openssl-dev@.../msg22324.html
> > 
> > dev-libs/openssl-0.9.8d works.
> > 
> > /haubi/
> > 
> 
> -- 
> Salomon Automation GmbH - Friesachstrasse 15 - A-8114 Friesach bei Graz
> Sitz der Gesellschaft: Friesach bei Graz
> UID-NR:ATU28654300 - Firmenbuchnummer: 49324 K
> Firmenbuchgericht: Landesgericht fur Zivilrechtssachen Graz
> 

> Index: openssl-0.9.8e.ebuild
> ===================================================================
> --- openssl-0.9.8e.ebuild	(revision 5558)
> +++ openssl-0.9.8e.ebuild	(working copy)
> @@ -102,6 +102,12 @@
>  		shared threads \
>  		|| die "Configure failed"
>  
> +	if [[ ${CHOST} == i?86*-*-linux* ]]; then
> +		# does not compile without optimization on x86-linux
> +		filter-flags -O0
> +		is-flagq -O* || append-flags -O1
> +	fi
> +
>  	# Clean out hardcoded flags that openssl uses
>  	local CFLAG=$(grep ^CFLAG= Makefile | LC_ALL=C sed \
>  		-e 's:^CFLAG=::' \


-- 
Fabian Groffen
Gentoo on a different level

-- 
gentoo-alt@g.o mailing list