| 1 |
On 03-03-2009 02:29:21 -0600, Johan Hattne wrote: |
| 2 |
> > Anyway, what is you host os version -- Tiger by chance? And the |
| 3 |
> > corresponding error message would be nice to have (judging from the |
| 4 |
> > patch I'd say missing _SC_NPROCESSORS_CONF). |
| 5 |
> |
| 6 |
> Yes, it is. I don't have a Leopard yet. Can't reproduce the exact |
| 7 |
> error message at the moment, but you're right--_SC_NPROCESSORS_CONF |
| 8 |
> isn't defined. |
| 9 |
|
| 10 |
Tiger here as well. |
| 11 |
|
| 12 |
> > About the patch: I would like to see the "#elif |
| 13 |
> > defined(_SC_NPROCESSORS_CONF)" case in front of the self-coded one (i.e. |
| 14 |
> > right after the _WIN32 case like before), since it's the xvid-default |
| 15 |
> > and working on 10.5. |
| 16 |
> |
| 17 |
> Makes perfect sense to me. I wrongly assumed that you couldn't have |
| 18 |
> __APPLE__ and __MACH__ and _SC_NPROCESSORS_CONF at the same time. Grobian? |
| 19 |
|
| 20 |
Well, I found it a bit strange, but the best thing IMO would be to |
| 21 |
configure check or #ifdef check for it. |
| 22 |
|
| 23 |
Without configure-foo, probably something like |
| 24 |
|
| 25 |
#ifndef _SC_NPROCESSORS_CONF |
| 26 |
# if defined(__MACH__) || defined(__BSD__) |
| 27 |
# include <blah> |
| 28 |
# doit(); |
| 29 |
# else |
| 30 |
# error don't know how to get the number of processors, should Google for it |
| 31 |
# endif |
| 32 |
#else |
| 33 |
# doit(_SC_NPROCESSORS_CONF); |
| 34 |
#endif |
| 35 |
|
| 36 |
|
| 37 |
-- |
| 38 |
Fabian Groffen |
| 39 |
Gentoo on a different level |
Archives