On 23-05-2007 23:58:48 +0200, Michael Haubenwallner wrote:
> > > +           s=${a%.a}.so
> > s = lib/libfoo.so.1.so
> > or
> > s = usr/lib/libfoo.so.so
> > I think this is wrong.  Is the replacement really necessary?  I think .a
> > has always been replaced in this case.
> 
> err, s is recreated from (still initial) $a, not (current) $s:

My bad.

> s = /D/prefix/usr/lib/libfoo.so
> 
> > >             s=${s%usr/*}${s##*/usr/}
> > s = lib/libfoo.so(.so)
> 
> s = /D/prefix/lib/libfoo.so
> 
> > > +           if [[ -L ${s} ]] && rs=$(readlink "${s}"); then
> 
> lib/libfoo.so could be a symlink '-> libfoo.so.1'.
> 
> rs = libfoo.so.1
> 
> Hmm, could this also be a symlink to somewhere outside lib/ ?
> Or even '-> /prefix/lib/libfoo.so.1' ?
> If not, we might not need to resolve symlinks (to $D) again here at all,
> as [[ -e ]] succeeds if symlink is resolveable.

I think it should exist.  Nothing more.  So -e should suffice.

> > > +               [[ ${rs} == /* ]] && s="${D}${rs}" || s="${ED}usr/lib/${rs}"
> > Hmmm... if s is a link, and it is relative, should it start from
> > ${ED}lib in that case?
> 
> oops, you're right, should read:
> +               [[ ${rs} == /* ]] && s="${D}${rs}" || s="${ED}lib/${rs}"

Let's commit it like this then...

-- 
Fabian Groffen
Gentoo on a different level

-- 
gentoo-alt@g.o mailing list