| 1 |
On Sun, Dec 29, 2013 at 05:50:51PM -0800, Brian Dolbec wrote: |
| 2 |
> +PORT_LOGDIR_CLEAN = \ |
| 3 |
> + 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete' |
| 4 |
|
| 5 |
Pulling out this global variable is new for v2. I don't think I'm a |
| 6 |
fan. I think it should either be hard-coded where we setup |
| 7 |
env["PORT_LOGDIR_CLEAN"] (as it was before) or pulled out of |
| 8 |
self.settings (like PORT_LOGDIR). |
| 9 |
|
| 10 |
> - self.mounts.append("/var/log/portage") |
| 11 |
> - self.mountmap["/var/log/portage"]=self.settings["port_logdir"] |
| 12 |
> - self.env["PORT_LOGDIR"]="/var/log/portage" |
| 13 |
> - self.env["PORT_LOGDIR_CLEAN"]='find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete' |
| 14 |
> + self.mounts.append("port_logdir") |
| 15 |
> + self.mountmap["port_logdir"] = self.settings["port_logdir"] |
| 16 |
> + self.env["PORT_LOGDIR"] = self.settings["port_logdir"] |
| 17 |
> + self.env["PORT_LOGDIR_CLEAN"] = PORT_LOGDIR_CLEAN |
| 18 |
|
| 19 |
Other than the newly-global PORT_LOGDIR_CLEAN, this looks good to me. |
| 20 |
|
| 21 |
Cheers, |
| 22 |
Trevor |
| 23 |
|
| 24 |
-- |
| 25 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 26 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives