| 1 |
Chris Gianelloni wrote: |
| 2 |
> On Wed, 2006-08-23 at 06:58 +0200, Bardur Arantsson wrote: |
| 3 |
>> I think the livecd_stage2_target.py should probably give the user a |
| 4 |
>> slightly more informative error message ;). |
| 5 |
> |
| 6 |
> Feel free to file a bug with a patch. Remember that catalyst isn't |
| 7 |
> really targeted for end-users (how many times do you hear that about a |
| 8 |
> project) but instead Gentoo developers. We release it mostly for |
| 9 |
> transparency reasons and because of our social contract. That being |
| 10 |
> said, we do work bug reports, especially ones with patches. |
| 11 |
> |
| 12 |
|
| 13 |
Fair enough, but bugs are meant to be squashed aren't they? ;) All your |
| 14 |
hard work _is_ appreciated even if it wasn't meant for general |
| 15 |
consumption :). |
| 16 |
|
| 17 |
I can't be bothered to open up a bug report, but I've attached a trivial |
| 18 |
patch. |
| 19 |
|
| 20 |
I think the logic in there still looks suspect though: AFAICT there may |
| 21 |
be other scenarios than the one I accidentally tried where 'unpack' may |
| 22 |
remain True while unpack_cmd does not get set to anything meaningful. |
| 23 |
With my patch this will result in the new error message as well -- I'm |
| 24 |
not sure how appropriate that is. |
| 25 |
|
| 26 |
Anyway, the patch certainly certainly shouldn't cause any regressions. |
| 27 |
The new message only triggers when an undefined variable would be |
| 28 |
accessed anyway. |
| 29 |
|
| 30 |
>>> The only thing resembling the file name above is the source_subpath |
| 31 |
>>> setting, but I'm not sure why that would get turned into a .tar.bz2 file |
| 32 |
>>> name by catalyst when catalyst itself clearly expects a directory name. |
| 33 |
>>> |
| 34 |
>> The "change to the name of a .tar.bz2" bit still puzzles me and I'm not |
| 35 |
>> sure it's desirable behavior. |
| 36 |
> |
| 37 |
> It is. It is all due to seedcache and how it works. It first searches |
| 38 |
> for a directory, then for a tarball. That's not saying that there isn't |
| 39 |
> a bug in there somewhere, but the design is to use a directory first |
| 40 |
> when options=seedcache and a tarball only otherwise for all targets |
| 41 |
> *except* livecd-stage2. |
| 42 |
> |
| 43 |
|
| 44 |
Ok, I'll take your word for it :). |
| 45 |
|
| 46 |
-- |
| 47 |
Bardur Arantsson |
| 48 |
<bardurREMOVE@×××××××××××××××.net> |
| 49 |
|
| 50 |
- I've got a plan so cunning, you could put a tail on it and call |
| 51 |
it a weasel. |
| 52 |
Edmund Blackadder, 'Blackadder' |
Archives