| 1 |
On Wed, Dec 18, 2013 at 09:18:06PM -0800, antarus@g.o wrote: |
| 2 |
> @@ -116,12 +115,13 @@ def parse_config(myconfig): |
| 3 |
> print "Setting",x,"to default value \""+confdefaults[x]+"\"" |
| 4 |
> conf_values[x]=confdefaults[x] |
| 5 |
> |
| 6 |
> + options = conf_values["options"].split() |
| 7 |
> # parse out the rest of the options from the config file |
| 8 |
> - if "autoresume" in string.split(conf_values["options"]): |
| 9 |
> + if "autoresume" in options: |
| 10 |
> print "Autoresuming support enabled." |
| 11 |
> conf_values["AUTORESUME"]="1" |
| 12 |
> |
| 13 |
> - if "bindist" in string.split(conf_values["options"]): |
| 14 |
> + if "bindist" in options: |
| 15 |
> print "Binary redistribution enabled" |
| 16 |
> conf_values["BINDIST"]="1" |
| 17 |
> else: |
| 18 |
|
| 19 |
These changes look fine to me, but I'd rather just convert to the |
| 20 |
stdlib's ConfigParser. That's going to blow away this whole function, |
| 21 |
so I don't see the point in fixing it up now. Of course, if the |
| 22 |
powers that be think a ConfigParser conversion is in the far-distant |
| 23 |
future, then I'm ok with this as a temporary cleanup. |
| 24 |
|
| 25 |
Cheers, |
| 26 |
Trevor |
| 27 |
|
| 28 |
-- |
| 29 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 30 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives