Re: [gentoo-catalyst] [PATCH 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary

[Brian Dolbec]

On Sat, 2013-12-28 at 19:52 -0800, W. Trevor King wrote:
> On Sat, Dec 28, 2013 at 06:49:11PM -0800, W. Trevor King wrote:
> > On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote:
> > > -		self.mounts.append("/tmp/stage1root/proc")
> > > -		self.mountmap["/tmp/stage1root/proc"]="/proc"
> > > +		self.mounts.append("stage1root/proc")
> > > +		self.target_mounts["stage1root/proc"] = "/tmp/stage1root/proc"
> > > +		self.mountmap["stage1root/proc"]="/proc"
> >
> > Hmm.  I'm not how this is handled at the moment, but don't we want:
> >
> >   mount -t proc none /tmp/stage1root/proc
> >
> > instead of:
> >
> >   mount --bind /proc /tmp/stage1root/proc
> >
> > The handbook is currently using --rbind as well [1].
> >
> > Maybe food for a future series :p.
>
> After Douglas Freed talked me off the devtmpfs ledge on
> #gentoo-releng, my current suggested mount changes are:
>
>   -t:
>     proc
>   --rbind:
>     sys
>     dev
>     portdir
>     port_logdir
>     port_tmpdir
>     kerncache
>     ccache
>     icecream
>   drop:
>     devpts (now that we --rbind /dev)
>     distdir (now that we --rbind portdir)
>     packagedir (now that we --rbind portdir)
>
> For distdir/packagedir, I'd be find if the source defaulted to None
> (meaning “don't mount anything”) but could be configured to a path
> (meaning “--rbind this after you've --rbind-mounted portdir”).
>
> Cheers,
> Trevor
>

This series of patches was to just fix the migration from hard coded
paths to centrally configurable ones.  These mount changes should be
commits unto themselves.  Please don't confuse the issues... we have
lots more changes to get through.   I'm not saying anything against your
proposed changes, just they're not for this commit.