Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 1/3] Remove some troublesome trailing slashes from paths
Date: Wed, 18 Dec 2013 05:41:09
Message-Id: 1387345252.3897.208.camel@big_daddy.dol-sen.ca
In Reply to: Re: [gentoo-catalyst] [PATCH 1/3] Remove some troublesome trailing slashes from paths by "W. Trevor King"
1 On Tue, 2013-12-17 at 19:41 -0800, W. Trevor King wrote:
2 > On Tue, Dec 17, 2013 at 05:12:09PM -0800, Brian Dolbec wrote:
3 > > - self.settings["snapshot"]+"/")
4 > > + self.settings["snapshot"])
5 > > …
6 > > - "/tmp/"+self.settings["target_subpath"]+"/")
7 > > + "/tmp/"+self.settings["target_subpath"])
8 > > …
9 > > - self.settings["version_stamp"]+"/")
10 > > + self.settings["version_stamp"])
11 >
12 > Acked by me, although I think path consumers should be able to handle
13 > both forms.
14 >
15 > Cheers,
16 > Trevor
17 >
18
19 They should, but I found catalyst's code to be fragile, fixing these
20 issues got things working again. I also found that once fixed, things
21 seemed to be more stable when making changes.
22
23 Plus I like it better when looking through output to see it not have //
24 or /// in the middle of a path.

Attachments

File name MIME type
signature.asc application/pgp-signature