Gentoo Archives: gentoo-commits

From: Lars Wendler <polynomial-c@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/mumble/files/, media-sound/mumble/
Date: Tue, 01 Mar 2022 10:26:48
Message-Id: 1646130399.583639c62e8515396d1d516cff9d1b66b12b151d.polynomial-c@gentoo
1 commit: 583639c62e8515396d1d516cff9d1b66b12b151d
2 Author: Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
3 AuthorDate: Tue Mar 1 10:26:15 2022 +0000
4 Commit: Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
5 CommitDate: Tue Mar 1 10:26:39 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=583639c6
7
8 media-sound/mumble: Drop merged patch
9
10 Signed-off-by: Lars Wendler <polynomial-c <AT> gentoo.org>
11
12 .../mumble/files/mumble-9999-system_json.patch | 60 ----------------------
13 media-sound/mumble/mumble-9999.ebuild | 4 --
14 2 files changed, 64 deletions(-)
15
16 diff --git a/media-sound/mumble/files/mumble-9999-system_json.patch b/media-sound/mumble/files/mumble-9999-system_json.patch
17 deleted file mode 100644
18 index bb04dc0a01e0..000000000000
19 --- a/media-sound/mumble/files/mumble-9999-system_json.patch
20 +++ /dev/null
21 @@ -1,60 +0,0 @@
22 -From a239ccf62369880a0b08faf01021e7961ec1cc5a Mon Sep 17 00:00:00 2001
23 -From: Robert Adam <dev@×××××××××××.de>
24 -Date: Fri, 25 Feb 2022 18:37:51 +0100
25 -Subject: [PATCH] BUILD(client): Add option to use system JSON lib
26 -
27 -This commit introduces an option that toggles between using a bundled
28 -version of nlohmann_json (default) and looking for a version installed
29 -on the system instead.
30 -
31 -Fixes #5584
32 ----
33 - docs/dev/build-instructions/cmake_options.md | 5 +++++
34 - src/mumble/CMakeLists.txt | 11 ++++++++---
35 - 2 files changed, 13 insertions(+), 3 deletions(-)
36 -
37 -diff --git a/docs/dev/build-instructions/cmake_options.md b/docs/dev/build-instructions/cmake_options.md
38 -index 2a02b200b7..b395251069 100644
39 ---- a/docs/dev/build-instructions/cmake_options.md
40 -+++ b/docs/dev/build-instructions/cmake_options.md
41 -@@ -34,6 +34,11 @@ Bundle Qt's translations as well
42 - Build the included version of CELT instead of looking for one on the system.
43 - (Default: ON)
44 -
45 -+### bundled-json
46 -+
47 -+Build the included version of nlohmann_json instead of looking for one on the system
48 -+(Default: ON)
49 -+
50 - ### bundled-opus
51 -
52 - Build the included version of Opus instead of looking for one on the system.
53 -diff --git a/src/mumble/CMakeLists.txt b/src/mumble/CMakeLists.txt
54 -index bb8df16714..5f1c14ba97 100644
55 ---- a/src/mumble/CMakeLists.txt
56 -+++ b/src/mumble/CMakeLists.txt
57 -@@ -27,6 +27,7 @@ option(bundled-celt "Build the included version of CELT instead of looking for o
58 - option(bundled-speex "Build the included version of Speex instead of looking for one on the system." ON)
59 - option(rnnoise "Use RNNoise for machine learning noise reduction." ON)
60 - option(bundled-rnnoise "Build the included version of RNNoise instead of looking for one on the system." ${rnnoise})
61 -+option(bundled-json "Build the included version of nlohmann_json instead of looking for one on the system" ON)
62 -
63 - option(manual-plugin "Include the built-in \"manual\" positional audio plugin." ON)
64 -
65 -@@ -472,9 +473,13 @@ else()
66 - endif()
67 -
68 -
69 --set(JSON_BuildTests OFF CACHE INTERNAL "")
70 --set(JSON_ImplicitConversions OFF CACHE INTERNAL "")
71 --add_subdirectory("${3RDPARTY_DIR}/nlohmann_json/" "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json/")
72 -+if(bundled-json)
73 -+ set(JSON_BuildTests OFF CACHE INTERNAL "")
74 -+ set(JSON_ImplicitConversions OFF CACHE INTERNAL "")
75 -+ add_subdirectory("${3RDPARTY_DIR}/nlohmann_json/" "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json/")
76 -+else()
77 -+ find_pkg("nlohmann_json" REQUIRED)
78 -+endif()
79 -
80 - target_link_libraries(mumble_client_object_lib PUBLIC nlohmann_json::nlohmann_json)
81 -
82
83 diff --git a/media-sound/mumble/mumble-9999.ebuild b/media-sound/mumble/mumble-9999.ebuild
84 index abee2e9d032d..7574a19a1ad6 100644
85 --- a/media-sound/mumble/mumble-9999.ebuild
86 +++ b/media-sound/mumble/mumble-9999.ebuild
87 @@ -71,10 +71,6 @@ BDEPEND="
88 src_prepare() {
89 sed '/TRACY_ON_DEMAND/s@ ON @ OFF @' -i src/CMakeLists.txt || die
90
91 - if [[ "${PV}" == *9999 ]] ; then
92 - PATCHES+=( "${FILESDIR}/${P}-system_json.patch" )
93 - fi
94 -
95 # required because of xdg.eclass also providing src_prepare
96 cmake_src_prepare
97 }