Gentoo Archives: gentoo-commits

From: Joonas Niilola <juippis@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: net-im/pidgin/
Date: Thu, 30 Jun 2022 07:51:15
Message-Id: 1656575466.a434ee9548bdb12437df73f007b247d946bf44ac.juippis@gentoo
1 commit: a434ee9548bdb12437df73f007b247d946bf44ac
2 Author: matoro <matoro <AT> users <DOT> noreply <DOT> github <DOT> com>
3 AuthorDate: Wed Jun 29 20:15:15 2022 +0000
4 Commit: Joonas Niilola <juippis <AT> gentoo <DOT> org>
5 CommitDate: Thu Jun 30 07:51:06 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a434ee95
7
8 net-im/pidgin: add IUSE=test with dev-libs/check dep
9
10 It turns out that if you "make check" without dev-libs/check installed,
11 rather than erroring it just runs and empty test suite that
12 automatically passes. Logic here:
13 https://keep.imfreedom.org/pidgin/pidgin/file/v2.14.10/configure.ac#l2456
14 You can actually see that Debian made the same mistake:
15 https://buildd.debian.org/status/fetch.php?pkg=pidgin&arch=amd64&ver=2.14.10-1&stamp=1654236435&raw=0
16
17 Bug: https://bugs.gentoo.org/848579
18 Closes: https://github.com/gentoo/gentoo/pull/26155
19 Signed-off-by: Joonas Niilola <juippis <AT> gentoo.org>
20
21 net-im/pidgin/pidgin-2.14.10.ebuild | 4 +++-
22 1 file changed, 3 insertions(+), 1 deletion(-)
23
24 diff --git a/net-im/pidgin/pidgin-2.14.10.ebuild b/net-im/pidgin/pidgin-2.14.10.ebuild
25 index e1c4288370b3..2b6b59d5482c 100644
26 --- a/net-im/pidgin/pidgin-2.14.10.ebuild
27 +++ b/net-im/pidgin/pidgin-2.14.10.ebuild
28 @@ -19,7 +19,8 @@ SLOT="0/2" # libpurple version
29 KEYWORDS="~alpha amd64 arm arm64 ~ia64 ~ppc ppc64 ~riscv ~sparc x86 ~amd64-linux ~x86-linux"
30 IUSE="aqua dbus debug doc eds gadu gnutls groupwise +gstreamer +gtk idn
31 meanwhile ncurses networkmanager nls perl pie prediction python sasl spell tcl
32 -tk v4l +xscreensaver zephyr zeroconf"
33 +test tk v4l +xscreensaver zephyr zeroconf"
34 +RESTRICT="!test? ( test )"
35
36 # dbus requires python to generate C code for dbus bindings (thus DEPEND only).
37 # finch uses libgnt that links with libpython - {R,}DEPEND. But still there is
38 @@ -90,6 +91,7 @@ BDEPEND="
39 virtual/pkgconfig
40 doc? ( app-doc/doxygen )
41 !gtk? ( nls? ( ${NLS_DEPEND} ) )
42 + test? ( >=dev-libs/check-0.9.4 )
43 "
44
45 DOCS=( AUTHORS HACKING NEWS README ChangeLog )