[gentoo-commits] gentoo-x86 commit in net-dialup/mgetty/files: mgetty-1.1.36-tmpfile.patch

[Alin Nastac (mrness)]

mrness      08/09/07 09:54:29

  Added:                mgetty-1.1.36-tmpfile.patch
  Log:
  Fix insecure temporary file usage (#235806).
  (Portage version: 2.1.4.4)

Revision  Changes    Path
1.1                  net-dialup/mgetty/files/mgetty-1.1.36-tmpfile.patch

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-dialup/mgetty/files/mgetty-1.1.36-tmpfile.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-dialup/mgetty/files/mgetty-1.1.36-tmpfile.patch?rev=1.1&content-type=text/plain

Index: mgetty-1.1.36-tmpfile.patch
===================================================================
diff -Nru mgetty-1.1.36.orig/fax/faxspool.in mgetty-1.1.36/fax/faxspool.in
--- mgetty-1.1.36.orig/fax/faxspool.in	2008-08-31 13:06:48.000000000 +0000
+++ mgetty-1.1.36/fax/faxspool.in	2008-09-07 09:44:01.000000000 +0000
@@ -675,9 +675,7 @@
     if [ x$file = x- ]
     then
 	$echo "spooling $file (stdin)..."
-	trap "rm /tmp/faxsp.$$" 0
-        cat - >/tmp/faxsp.$$
-	file=/tmp/faxsp.$$
+	file=$spooldir/faxsp
     else
 	$echo "spooling $file..."
     fi
@@ -924,7 +922,7 @@
 then
     $echo "\nnothing to do (no cover page, no data)." >&2
     cd $FAX_SPOOL_OUT
-    rmdir $spooldir
+    rm -rf $spooldir
     exit 52
 fi
 
@@ -965,7 +963,7 @@
 # clean up
 rm $job.q
 cd ..
-rmdir $spooldir
+rm -rf $spooldir
 
 if [ -z "`find $LAST_RUN -ctime -1 -print 2>/dev/null`" ]
 then