[gentoo-commits] gentoo-projects commit in forums/htdocs/admin: admin_forums.php

[Robin H. Johnson (robbat2)]

robbat2     10/09/09 17:10:15

  Modified:             admin_forums.php
  Log:
  This could be a replication failure source later, but unlikely for now, so just a TODO.

Revision  Changes    Path
1.6                  forums/htdocs/admin/admin_forums.php

file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/admin/admin_forums.php?rev=1.6&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/admin/admin_forums.php?rev=1.6&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/forums/htdocs/admin/admin_forums.php?r1=1.5&r2=1.6

Index: admin_forums.php
===================================================================
RCS file: /var/cvsroot/gentoo-projects/forums/htdocs/admin/admin_forums.php,v
retrieving revision 1.5
retrieving revision 1.6
diff -p -w -b -B -u -u -r1.5 -r1.6
--- admin_forums.php	30 Jul 2009 06:38:50 -0000	1.5
+++ admin_forums.php	9 Sep 2010 17:10:15 -0000	1.6
@@ -6,7 +6,7 @@
  *   copyright            : (C) 2001 The phpBB Group
  *   email                : support@×××××.com
  *
- *   $Id: admin_forums.php,v 1.5 2009/07/30 06:38:50 desultory Exp $
+ *   $Id: admin_forums.php,v 1.6 2010/09/09 17:10:15 robbat2 Exp $
  *
  ***************************************************************************/
 
@@ -439,6 +439,8 @@ if( !empty($mode) ) 
 
 			$next_order = ($parent_id == NO_PARENT) ? $max_order + 100 : $max_order + 10;
 
+			// TODO: this is not replication-safe - robbat2 2010/09/09
+			// Not fixing yet as creation of a forum is very rare.
 			$sql = "SELECT MAX(forum_id) AS max_id
 				FROM " . FORUMS_TABLE;
 			if( !$result = $db->sql_query($sql) )