Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-commits
Navigation:
Lists: gentoo-commits: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-commits@g.o
From: "Zac Medico (zmedico)" <zmedico@g.o>
Subject: portage r11686 - main/trunk/pym/_emerge
Date: Sun, 12 Oct 2008 23:57:31 +0000
Author: zmedico
Date: 2008-10-12 23:57:29 +0000 (Sun, 12 Oct 2008)
New Revision: 11686

Modified:
   main/trunk/pym/_emerge/__init__.py
Log:
Bug #234301 - When fetch fails, include the path of the log file in the
eerror message that's generated. This way it's easy for the user to find
the output from the fetcher or from the pkg_nofetch phase.


Modified: main/trunk/pym/_emerge/__init__.py
===================================================================
--- main/trunk/pym/_emerge/__init__.py	2008-10-12 23:17:56 UTC (rev 11685)
+++ main/trunk/pym/_emerge/__init__.py	2008-10-12 23:57:29 UTC (rev 11686)
@@ -2313,14 +2313,19 @@
 				if self.logfile is not None:
 					if self.background:
 						elog_out = open(self.logfile, 'a')
-				eerror("Fetch failed for '%s'" % self.pkg.cpv,
-					phase="unpack", key=self.pkg.cpv, out=elog_out)
+				msg = "Fetch failed for '%s'" % (self.pkg.cpv,)
+				if self.logfile is not None:
+					msg += ", Log file:"
+				eerror(msg, phase="unpack", key=self.pkg.cpv, out=elog_out)
+				if self.logfile is not None:
+					eerror(" '%s'" % (self.logfile,),
+						phase="unpack", key=self.pkg.cpv, out=elog_out)
 				if elog_out is not None:
 					elog_out.close()
 			if not self.prefetch:
 				portage.elog.elog_process(self.pkg.cpv, self._build_dir.settings)
 			features = self._build_dir.settings.features
-			if self.fetchonly or self.returncode == os.EX_OK:
+			if self.returncode == os.EX_OK:
 				self._build_dir.clean()
 			self._build_dir.unlock()
 			self.config_pool.deallocate(self._build_dir.settings)



Navigation:
Lists: gentoo-commits: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
portage r11685 - in main/trunk/pym: _emerge portage
Next by thread:
portage r11687 - main/trunk/pym/portage
Previous by date:
portage r11685 - in main/trunk/pym: _emerge portage
Next by date:
portage r11687 - main/trunk/pym/portage


Updated Sep 10, 2010

Summary: Archive of the gentoo-commits mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.