Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-commits
Navigation:
Lists: gentoo-commits: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-commits@g.o
From: "Zac Medico (zmedico)" <zmedico@g.o>
Subject: portage r11702 - main/trunk/pym/_emerge
Date: Sun, 19 Oct 2008 17:33:15 +0000
Author: zmedico
Date: 2008-10-19 17:33:14 +0000 (Sun, 19 Oct 2008)
New Revision: 11702

Modified:
   main/trunk/pym/_emerge/__init__.py
Log:
Remove the "found_available_arg" variable from depgraph._select_pkg() and use
the "matched_packages" variable instead. This solve a problem where the
"found_available_arg" flag is unreliable due to the slot filtering behavior
of depgraph._iter_atoms_for_pkg(). For example, a higher version in a
different slot than the available ebuild might be masked or unavailable, and
depgraph._iter_atoms_for_pkg() will not identify the available ebuild as
a match due to this installed package (which is not available for reinstall).


Modified: main/trunk/pym/_emerge/__init__.py
===================================================================
--- main/trunk/pym/_emerge/__init__.py	2008-10-18 20:17:04 UTC (rev 11701)
+++ main/trunk/pym/_emerge/__init__.py	2008-10-19 17:33:14 UTC (rev 11702)
@@ -5417,9 +5417,7 @@
 		# Therefore, "selective" logic does not consider
 		# whether or not an installed package matches an
 		# argument atom. It only considers whether or not
-		# available packages match argument atoms, which is
-		# represented by the found_available_arg flag.
-		found_available_arg = False
+		# available packages match argument atoms.
 		for find_existing_node in True, False:
 			if existing_node:
 				break
@@ -5428,7 +5426,7 @@
 					break
 				if installed and not find_existing_node:
 					want_reinstall = reinstall or empty or \
-						(found_available_arg and not selective)
+						(matched_packages and not selective)
 					if want_reinstall and matched_packages:
 						continue
 				if hasattr(db, "xmatch"):
@@ -5568,8 +5566,6 @@
 							if not installed:
 								# masked by corruption
 								continue
-					if not installed and myarg:
-						found_available_arg = True
 
 					if atom.use and not pkg.built:
 						use = pkg.use.enabled



Navigation:
Lists: gentoo-commits: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
gentoo-x86 commit in app-office/openoffice: openoffice-3.0.0.ebuild
Next by thread:
gentoo-x86 commit in dev-haskell/cabal: ChangeLog cabal-1.6.0.1.ebuild
Previous by date:
gentoo-x86 commit in app-office/openoffice: openoffice-3.0.0.ebuild
Next by date:
gentoo-x86 commit in dev-haskell/cabal: ChangeLog cabal-1.6.0.1.ebuild


Updated Aug 14, 2010

Summary: Archive of the gentoo-commits mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.