Gentoo Archives: gentoo-commits

From: "Zac Medico (zmedico)" <zmedico@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] portage r12016 - main/trunk/pym/_emerge
Date: Fri, 21 Nov 2008 21:28:13
Message-Id: E1L3dXu-00054h-Kq@stork.gentoo.org
1 Author: zmedico
2 Date: 2008-11-21 21:28:09 +0000 (Fri, 21 Nov 2008)
3 New Revision: 12016
4
5 Modified:
6 main/trunk/pym/_emerge/__init__.py
7 Log:
8 In EbuildProcess._start(), don't open the log file during the clean phase
9 since the open file can result in an nfs lock on $T/build.log which prevents
10 the clean phase from removing $T. Thanks to Jeremy Olexa <darkside@g.o> for
11 reporting.
12
13
14 Modified: main/trunk/pym/_emerge/__init__.py
15 ===================================================================
16 --- main/trunk/pym/_emerge/__init__.py 2008-11-21 08:24:22 UTC (rev 12015)
17 +++ main/trunk/pym/_emerge/__init__.py 2008-11-21 21:28:09 UTC (rev 12016)
18 @@ -2885,7 +2885,11 @@
19 __slots__ = ("phase", "pkg", "settings", "tree")
20
21 def _start(self):
22 - self.logfile = self.settings.get("PORTAGE_LOG_FILE")
23 + # Don't open the log file during the clean phase since the
24 + # open file can result in an nfs lock on $T/build.log which
25 + # prevents the clean phase from removing $T.
26 + if self.phase not in ("clean", "cleanrm"):
27 + self.logfile = self.settings.get("PORTAGE_LOG_FILE")
28 SpawnProcess._start(self)
29
30 def _pipe(self, fd_pipes):