[gentoo-commits] gentoo-x86 commit in eclass: git-2.eclass webapp.eclass

[Tomas Chvatal (scarabeus)]

scarabeus    11/05/19 12:03:41

  Modified:             git-2.eclass webapp.eclass
  Log:
  Add EGIT_PROJECT variable that allows us to specify folder where to check out the git repository.

Revision  Changes    Path
1.6                  eclass/git-2.eclass

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/git-2.eclass?rev=1.6&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/git-2.eclass?rev=1.6&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/git-2.eclass?r1=1.5&r2=1.6

Index: git-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/git-2.eclass,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- git-2.eclass	2 May 2011 21:15:30 -0000	1.5
+++ git-2.eclass	19 May 2011 12:03:41 -0000	1.6
@@ -1,6 +1,6 @@
 # Copyright 1999-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/git-2.eclass,v 1.5 2011/05/02 21:15:30 mgorny Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/git-2.eclass,v 1.6 2011/05/19 12:03:41 scarabeus Exp $
 
 # @ECLASS: git-2.eclass
 # @MAINTAINER:
@@ -46,12 +46,20 @@
 #
 # EGIT_MASTER="master"
 
+# @ECLASS-VARIABLE: EGIT_PROJECT
+# @DESCRIPTION:
+# Variable specifying name for the folder where we check out the git
+# repository. Value of this variable should be unique in the
+# EGIT_STORE_DIR as otherwise you would override another repository.
+#
+# EGIT_PROJECT="${EGIT_REPO_URI##*/}"
+
 # @ECLASS-VARIABLE: EGIT_DIR
 # @DESCRIPTION:
 # Directory where we want to store the git data.
 # This should not be overriden unless really required.
 #
-# EGIT_DIR="${EGIT_STORE_DIR}/${EGIT_REPO_URI##*/}"
+# EGIT_DIR="${EGIT_STORE_DIR}/${EGIT_PROJECT}"
 
 # @ECLASS-VARIABLE: EGIT_REPO_URI
 # @REQUIRED
@@ -235,9 +243,15 @@
 	# allow writing into EGIT_STORE_DIR
 	addwrite "${EGIT_STORE_DIR}"
 	# calculate the proper store dir for data
+	# If user didn't specify the EGIT_DIR, we check if he did specify
+	# the EGIT_PROJECT or get the folder name from EGIT_REPO_URI.
 	[[ -z ${EGIT_REPO_URI##*/} ]] && EGIT_REPO_URI="${EGIT_REPO_URI%/}"
 	if [[ -z ${EGIT_DIR} ]]; then
-		clone_dir=${EGIT_REPO_URI##*/}
+		if [[ -n ${EGIT_PROJECT} ]]; then
+			clone_dir=${EGIT_PROJECT}
+		else
+			clone_dir=${EGIT_REPO_URI##*/}
+		fi
 		EGIT_DIR=${EGIT_STORE_DIR}/${clone_dir}
 	fi
 	export EGIT_DIR=${EGIT_DIR}



1.65                 eclass/webapp.eclass

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/webapp.eclass?rev=1.65&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/webapp.eclass?rev=1.65&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/webapp.eclass?r1=1.64&r2=1.65

Index: webapp.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/webapp.eclass,v
retrieving revision 1.64
retrieving revision 1.65
diff -u -r1.64 -r1.65
--- webapp.eclass	9 May 2010 22:32:16 -0000	1.64
+++ webapp.eclass	19 May 2011 12:03:41 -0000	1.65
@@ -1,6 +1,6 @@
-# Copyright 1999-2006 Gentoo Foundation
+# Copyright 1999-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/webapp.eclass,v 1.64 2010/05/09 22:32:16 darkside Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/webapp.eclass,v 1.65 2011/05/19 12:03:41 scarabeus Exp $
 
 # @ECLASS: webapp.eclass
 # @MAINTAINER:
@@ -10,26 +10,37 @@
 # The webapp eclass contains functions to handle web applications with
 # webapp-config. Part of the implementation of GLEP #11
 
+# @ECLASS-VARIABLE: WABAPP_MINIMAL
+# @DESCRIPTION:
+# Minimal version of webapp-config the package requires for sucessfull install.
+: ${WEBAPP_MINIMAL:=1.50.15}
+
 # @ECLASS-VARIABLE: WEBAPP_DEPEND
 # @DESCRIPTION:
 # An ebuild should use WEBAPP_DEPEND if a custom DEPEND needs to be built, most
 # notably in combination with WEBAPP_OPTIONAL.
-WEBAPP_DEPEND=">=app-admin/webapp-config-1.50.15"
+: ${WEBAPP_DEPEND:=">=app-admin/webapp-config-${WEBAPP_MINIMAL}"}
 
-# @ECLASS-VARIABLE: WEBAPP_NO_AUTO_INSTALL
+# @ECLASS-VARIABLE: WEBAPP_AUTO_INSTALL
 # @DESCRIPTION:
-# An ebuild sets this to `yes' if an automatic installation and/or upgrade is
+# An ebuild sets this to `no' if an automatic installation and/or upgrade is
 # not possible. The ebuild should overwrite pkg_postinst() and explain the
 # reason for this BEFORE calling webapp_pkg_postinst().
+: ${WEBAPP_AUTO_INSTALL:=yes}
+if [[ -n ${WEBAPP_NO_AUTO_INSTALL} ]]; then
+	WEBAPP_AUTO_INSTALL=no
+	ewarn "QA: using deprecated variable \"WEBAPP_NO_AUTO_INSTALL\"."
+	ewarn "QA: please migrate to WEBAPP_AUTO_INSTALL with inverse logic"
+	ewarn "QA: that defaults to yes."
+fi
 
 # @ECLASS-VARIABLE: WEBAPP_OPTIONAL
 # @DESCRIPTION:
 # An ebuild sets this to `yes' to make webapp support optional, in which case
 # you also need to take care of USE-flags and dependencies.
-
-if [[ "${WEBAPP_OPTIONAL}" != "yes" ]]; then
-	[[ "${WEBAPP_NO_AUTO_INSTALL}" == "yes" ]] || IUSE="vhosts"
-	SLOT="${PVR}"
+if [[ ${WEBAPP_OPTIONAL} != yes ]]; then
+	[[ ${WEBAPP_AUTO_INSTALL} == yes ]] && IUSE="vhosts"
+	: ${SLOT:=${PVR}}
 	DEPEND="${WEBAPP_DEPEND}"
 	RDEPEND="${DEPEND}"
 fi
@@ -56,22 +67,18 @@
 webapp_read_config() {
 	debug-print-function $FUNCNAME $*
 
-	if has_version '>=app-admin/webapp-config-1.50'; then
-		ENVVAR=$(${WEBAPP_CONFIG} --query ${PN} ${PVR}) || die "Could not read settings from webapp-config!"
-		eval ${ENVVAR}
-	else
-		. ${ETC_CONFIG} || die "Unable to read ${ETC_CONFIG}"
-	fi
+	ENVVAR=$(${WEBAPP_CONFIG} --query ${PN} ${PVR}) || die "Could not read settings from webapp-config!"
+	eval ${ENVVAR} || die
 }
 
 # Check whether a specified file exists in the given directory (`.' by default)
 webapp_checkfileexists() {
 	debug-print-function $FUNCNAME $*
 
-	local my_prefix=${2:+${2}/}
+	local msg my_prefix=${2:+${2}/}
 
 	if [[ ! -e "${my_prefix}${1}" ]]; then
-		msg="ebuild fault: file '${1}' not found"
+		msg="ebuild error: file '${1}' not found"
 		eerror "$msg"
 		eerror "Please report this as a bug at http://bugs.gentoo.org/"
 		die "$msg"
@@ -101,19 +108,20 @@
 webapp_getinstalltype() {
 	debug-print-function $FUNCNAME $*
 
+	local my_output my_pn my_pvr
+
 	if ! has vhosts ${IUSE} || use vhosts; then
 		return
 	fi
 
-	local my_output
 	my_output="$(webapp_check_installedat)"
 
 	if [[ $? -eq 0 ]]; then
 		# something is already installed there
 		# make sure it isn't the same version
 
-		local my_pn="$(echo ${my_output} | awk '{ print $1 }')"
-		local my_pvr="$(echo ${my_output} | awk '{ print $2 }')"
+		my_pn="$(echo ${my_output} | awk '{ print $1 }')"
+		my_pvr="$(echo ${my_output} | awk '{ print $2 }')"
 
 		REMOVE_PKG="${my_pn}-${my_pvr}"
 
@@ -133,6 +141,18 @@
 	fi
 }
 
+# helper for webapp_serverowned()
+_webapp_serverowned() {
+	debug-print-function $FUNCNAME $*
+
+	webapp_checkfileexists "${1}" "${D}"
+	local my_file="$(webapp_strip_appdir "${1}")"
+	my_file="$(webapp_strip_cwd "${my_file}")"
+
+	elog "(server owned) ${my_file}"
+	echo "${my_file}" >> "${D}/${WA_SOLIST}"
+}
+
 # ==============================================================================
 # PUBLIC FUNCTIONS
 # ==============================================================================
@@ -171,6 +191,8 @@
 webapp_configfile() {
 	debug-print-function $FUNCNAME $*
 
+	[[ $# -lt 1 ]] && die "${FUNCNAME}: I require at least 1 argument. Please read eclass documentation."
+
 	local m
 	for m in "$@"; do
 		webapp_checkfileexists "${m}" "${D}"
@@ -178,62 +200,75 @@
 		local my_file="$(webapp_strip_appdir "${m}")"
 		my_file="$(webapp_strip_cwd "${my_file}")"
 
-		elog "(config) ${my_file}"
+		elog "[webapp-config] ${my_file}"
 		echo "${my_file}" >> ${D}/${WA_CONFIGLIST}
 	done
 }
 
 # @FUNCTION: webapp_hook_script
-# @USAGE: <file>
+# @USAGE: <file> [more files ...]
 # @DESCRIPTION:
 # Install a script that will run after a virtual copy is created, and
 # before a virtual copy has been removed.
 webapp_hook_script() {
 	debug-print-function $FUNCNAME $*
 
-	webapp_checkfileexists "${1}"
+	[[ $# -lt 1 ]] && die "${FUNCNAME}: I require at least 1 argument. Please read eclass documentation."
+
+	local m
+	for m in "$@"; do
+		webapp_checkfileexists "${m}"
 
-	elog "(hook) ${1}"
-	cp "${1}" "${D}/${MY_HOOKSCRIPTSDIR}/$(basename "${1}")" || die "Unable to install ${1} into ${D}/${MY_HOOKSCRIPTSDIR}/"
-	chmod 555 "${D}/${MY_HOOKSCRIPTSDIR}/$(basename "${1}")"
+		elog "[webapp-hook] ${m}"
+		cp "${1}" "${D}/${MY_HOOKSCRIPTSDIR}/$(basename "${1}")" || die "Unable to install ${1} into \"${D}/${MY_HOOKSCRIPTSDIR}/\""
+		chmod 555 "${D}/${MY_HOOKSCRIPTSDIR}/$(basename "${1}")"
+	done
 }
 
 # @FUNCTION: webapp_postinst_txt
-# @USAGE: <lang> <file>
+# @USAGE: <lang> <file> [more files ...]
 # @DESCRIPTION:
 # Install a text file containing post-installation instructions.
 webapp_postinst_txt() {
 	debug-print-function $FUNCNAME $*
 
-	webapp_checkfileexists "${2}"
+	local lang m
 
-	elog "(info) ${2} (lang: ${1})"
-	cp "${2}" "${D}/${MY_APPDIR}/postinst-${1}.txt"
+	[[ $# -lt 2 ]] && die "${FUNCNAME}: I require at least 2 arguments. Please read eclass documentation."
+
+	lang=${1}
+	shift
+
+	local m
+	for m in "$@"; do
+		webapp_checkfileexists "${m}"
+
+		elog "[webapp-info] \"${m}\" (lang: ${lang})"
+		cp "${m}" "${D}/${MY_APPDIR}/${m}-postinst-${lang}.txt" || die
+	done
 }
 
 # @FUNCTION: webapp_postupgrade_txt
-# @USAGE: <lang> <file>
+# @USAGE: <lang> <file> [more files ...]
 # @DESCRIPTION:
 # Install a text file containing post-upgrade instructions.
 webapp_postupgrade_txt() {
 	debug-print-function $FUNCNAME $*
 
-	webapp_checkfileexists "${2}"
+	local lang m
 
-	elog "(info) ${2} (lang: ${1})"
-	cp "${2}" "${D}/${MY_APPDIR}/postupgrade-${1}.txt"
-}
+	[[ $# -lt 2 ]] && die "${FUNCNAME}: I require at least 2 arguments. Please read eclass documentation."
 
-# helper for webapp_serverowned()
-_webapp_serverowned() {
-	debug-print-function $FUNCNAME $*
+	lang=${1}
+	shift
 
-	webapp_checkfileexists "${1}" "${D}"
-	local my_file="$(webapp_strip_appdir "${1}")"
-	my_file="$(webapp_strip_cwd "${my_file}")"
+	local m
+	for m in "$@"; do
+		webapp_checkfileexists "${m}"
 
-	elog "(server owned) ${my_file}"
-	echo "${my_file}" >> "${D}/${WA_SOLIST}"
+		elog "[webapp-info] \"${m}\" (lang: ${lang})"
+		cp "${m}" "${D}/${MY_APPDIR}/${m}-postupgrade-${lang}.txt" || die
+	done
 }
 
 # @FUNCTION: webapp_serverowned
@@ -271,6 +306,8 @@
 webapp_server_configfile() {
 	debug-print-function $FUNCNAME $*
 
+	[[ $# -lt 2 ]] && die "${FUNCNAME}: I require at least 2 arguments. Please read eclass documentation."
+
 	webapp_checkfileexists "${2}"
 
 	# WARNING:
@@ -280,7 +317,7 @@
 
 	local my_file="${1}-${3:-$(basename "${2}")}"
 
-	elog "(${1}) config file '${my_file}'"
+	elog "[webapp] Server \"${1}\" config file \"${my_file}\""
 	cp "${2}" "${D}/${MY_SERVERCONFIGDIR}/${my_file}"
 }
 
@@ -294,23 +331,23 @@
 webapp_sqlscript() {
 	debug-print-function $FUNCNAME $*
 
-	webapp_checkfileexists "${2}"
+	[[ $# -lt 2 ]] && die "${FUNCNAME}: I require at least 2 arguments. Please read eclass documentation."
 
-	dodir "${MY_SQLSCRIPTSDIR}/${1}"
+	webapp_checkfileexists "${2}"
 
 	# WARNING:
 	#
 	# do NOT change the naming convention used here without changing all
 	# the other scripts that also rely upon these names
 
-	if [[ -n "${3}" ]]; then
-		elog "(${1}) upgrade script for ${PN}-${3} to ${PVR}"
-		cp "${2}" "${D}${MY_SQLSCRIPTSDIR}/${1}/${3}_to_${PVR}.sql"
-		chmod 600 "${D}${MY_SQLSCRIPTSDIR}/${1}/${3}_to_${PVR}.sql"
+	insinto "${MY_SQLSCRIPTSDIR}/${1}"
+	insopts -m0600
+	if [[ -n ${3} ]]; then
+		elog "[webapp] DB: \"${1}\" upgrade script for ${PN}-${3} to ${PVR}"
+		newins "${2}" "${3}_to_${PVR}.sql" || die
 	else
-		elog "(${1}) create script for ${PN}-${PVR}"
-		cp "${2}" "${D}/${MY_SQLSCRIPTSDIR}/${1}/${PVR}_create.sql"
-		chmod 600 "${D}/${MY_SQLSCRIPTSDIR}/${1}/${PVR}_create.sql"
+		elog "[webapp] DB: \"${1}\" create script for ${PN}-${PVR}"
+		newins "${2}" "${PVR}_create.sql"
 	fi
 }
 
@@ -322,7 +359,7 @@
 	debug-print-function $FUNCNAME $*
 
 	# sanity checks, to catch bugs in the ebuild
-	if [[ ! -f "${T}/${SETUP_CHECK_FILE}" ]]; then
+	if [[ ! -f ${T}/${SETUP_CHECK_FILE} ]]; then
 		eerror
 		eerror "This ebuild did not call webapp_pkg_setup() at the beginning"
 		eerror "of the pkg_setup() function"
@@ -371,9 +408,8 @@
 	touch "${T}/${SETUP_CHECK_FILE}"
 
 	# special case - some ebuilds *do* need to overwride the SLOT
-	if [[ "${SLOT}+" != "${PVR}+" && "${WEBAPP_MANUAL_SLOT}" != "yes" ]]; then
+	[[ ${SLOT} != ${PVR} && ${WEBAPP_MANUAL_SLOT} != yes ]] && \
 		die "Set WEBAPP_MANUAL_SLOT=\"yes\" if you need to SLOT manually"
-	fi
 
 	# pull in the shared configuration file
 	G_HOSTNAME="localhost"
@@ -391,17 +427,14 @@
 
 	if [[ $? -ne 0 ]]; then
 		# okay, whatever is there, it isn't webapp-config-compatible
-		echo
 		ewarn
 		ewarn "You already have something installed in ${my_dir}"
 		ewarn
-		ewarn "Whatever is in ${my_dir}, it's not"
+		ewarn "Whatever is in \"${my_dir}\", it's not"
 		ewarn "compatible with webapp-config."
 		ewarn
 		ewarn "This ebuild may be overwriting important files."
 		ewarn
-		echo
-		ebeep 10
 	elif [[ "$(echo ${my_output} | awk '{ print $1 }')" != "${PN}" ]]; then
 		echo
 		eerror "You already have ${my_output} installed in ${my_dir}"
@@ -411,7 +444,6 @@
 		echo
 		die "Cannot upgrade contents of ${my_dir}"
 	fi
-
 }
 
 # @FUNCTION: webapp_src_install
@@ -479,23 +511,22 @@
 			local my_mode=-I
 			webapp_getinstalltype
 
-			if [[ "${IS_REPLACE}" == "1" ]]; then
-				elog "${PN}-${PVR} is already installed - replacing"
-				my_mode=-I
-			elif [[ "${IS_UPGRADE}" == "1" ]]; then
-				elog "${REMOVE_PKG} is already installed - upgrading"
+			if [[ ${IS_REPLACE} == 1 ]]; then
+				elog "[webapp] ${PN}-${PVR} is already installed - replacing"
+			elif [[ ${IS_UPGRADE} == 1 ]]; then
+				elog "[webapp] ${REMOVE_PKG} is already installed - upgrading"
 				my_mode=-U
 			else
-				elog "${PN}-${PVR} is not installed - using install mode"
+				elog "[webapp] ${PN}-${PVR} is not installed - using install mode"
 			fi
 
 			my_cmd="${WEBAPP_CONFIG} ${my_mode} -h localhost -u root -d ${INSTALL_DIR} ${PN} ${PVR}"
-			elog "Running ${my_cmd}"
+			elog "[webapp] Running ${my_cmd}"
 			${my_cmd}
 
 			echo
 			local cleaner="${WEBAPP_CLEANER} -p -C ${PN}"
-			einfo "Running ${cleaner}"
+			einfo "[webapp] Running ${cleaner}"
 			${cleaner}
 		else
 			elog
@@ -544,10 +575,10 @@
 					${WEBAPP_CONFIG} -C -h ${WEB_HOSTNAME} -d ${WEB_INSTALLDIR}
 				fi
 			else
-				ewarn "Cannot find file ${x}/.webapp"
+				ewarn "[webapp] Cannot find file ${x}/.webapp"
 			fi
 		done
-	elif [[ "${my_output}" != "" ]]; then
+	elif [[ -n ${my_output} ]]; then
 		echo
 		ewarn
 		ewarn "Don't forget to use webapp-config to remove any copies of"
@@ -556,9 +587,9 @@
 
 		echo "${my_output}" | while read x; do
 			if [[ -f "${x}"/.webapp ]]; then
-				ewarn "    ${x}"
+				ewarn "[webapp]    ${x}"
 			else
-				ewarn "Cannot find file ${x}/.webapp"
+				ewarn "[webapp] Cannot find file ${x}/.webapp"
 			fi
 		done