Gentoo Archives: gentoo-desktop

From: Chris Bandy <cbandy@××××××.com>
To: gentoo-desktop@l.g.o
Subject: Re: [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass
Date: Mon, 22 Feb 2010 03:24:49
Message-Id: 4B81F8CC.4080205@jbandy.com
In Reply to: Re: [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass by Martin von Gagern
1 Martin von Gagern wrote:
2 > On 21.02.2010 15:53, Chris Bandy wrote:
3 >
4 >> As a more comprehensive test, I rebuilt everything I had in
5 >> kde-sunset[1]. Everything regarding PATCHES worked great!
6 >>
7 >
8 > Thanks a lot, I appreciate that testing!
9 >
10 >
11 >> However, I had to make three changes to individual ebuilds:
12 >>
13 >> 1. Had to remove x11-libs/qt/qt-3.3.8-libpng14.patch because it was not
14 >> in the Manifest
15 >>
16 >
17 > Committed by Ladislav in f7ba03a46f179acb658a9775a75972fa3d2b68c5
18 >
19 >
20 >> 2. Had to modify app-text/poppler/poppler-0.12.3-r3.ebuild as described
21 >> here: http://forums.gentoo.org/viewtopic-p-6170313.html#6170313
22 >>
23 >
24 > Committed by me in 5ba737169016a164646bbfe1da53cbf7f34d137f
25 >
26 >
27 >> 3. Had to revert kde-base/kdepim-kresources-3.5.10.ebuild back to EAPI=1
28 >>
29 >
30 > Committed by Ladislav in 5be5829c56380ca6ff08775d814558d936f816cc
31 >
32 >
33 >> I've attached a log for the failed EAPI=2 build in #3.
34 >>
35 >
36 > I've had a look. Could reproduce the issue here, and could diff both
37 > runs. One of the first differences I noted was this:
38 >
39 > EAPI=1: checking if libkcal should be compiled... no
40 > EAPI=2: checking if libkcal should be compiled... yes
41 >
42 > This output is, of course, from configure. If you look at the ebuild,
43 > you notice that it disables libkcal via an environment variable:
44 >
45 > src_compile() {
46 > export DO_NOT_COMPILE="knotes libkcal"
47 >
48 > This is only done in src_compile, i.e. after src_configure has already
49 > completed. Only in EAPI=1, where there is no src_configure phase, but
50 > instead a configure stage of the kde-meta_src_compile function, setting
51 > the variable in this fashion gives the desired result.
52 >
53 > I've written a EAPI=2 version of the ebuild that avoids these issues. It
54 > works for me, so I decided to commit it, just in case we'll want to use
55 > EAPI=2 in the future.
56 >
57 > Committed by me in 1a496ce8440c3b8781be988df65ecc77ea267e6b
58 >
59 > Greetings,
60 > Martin von Gagern
61 >
62
63 I re-emerged everything I had in kde-sunset[1] again. No build errors;
64 everything works! Thanks!
65
66 [1] 1a496ce8440c3b8781be988df65ecc77ea267e6b
67
68 -- Chris

Replies

Subject Author
Re: [gentoo-desktop] kde-sunset: Calling base_src_prepare from kde.eclass Andrew John Hughes <gnu_andrew@××××××××××.org>