Gentoo Archives: gentoo-desktop

From: Ladislav Laska <ladislav.laska@×××××.com>
To: gentoo-desktop@l.g.o
Subject: Re: [gentoo-desktop] kde-sunset: kdepim-kresources broken
Date: Fri, 19 Feb 2010 12:15:13
Message-Id: 255f067f1002190414k67a1af76pb7b6a06dcff5570e@mail.gmail.com
In Reply to: Re: [gentoo-desktop] kde-sunset: kdepim-kresources broken by Chris Bandy
Yes, but that's not the problem. You see, the commit you're mentioning
removes hack, but another hack is still present in kde-meta, which
prevents prepare from base.eclass to be invoked (another "dummy"
function). Removing this, only src_prepare in ebuild or in base.eclass
can be invoked, both of them will do just fine.

Unfortunately, src_prepare is eapi=2 thing, so we have to migrate all
packages with patches to eapi 2, but this should not be a problem,
since i've seen someone is already doing that.

Anyway, I'll commit patch which will at least fix things for eapi 2.

Regards Ladislav Laska
S pozdravem Ladislav Laska
---
xmpp/jabber: ladislav.laska@××××××.cz



On Fri, Feb 19, 2010 at 8:26 AM, Chris Bandy <cbandy@××××××.com> wrote:
> Chris Bandy wrote: >> Ladislav Laska wrote: >> >>> Some more info: >>> >>> PATCHES are handled in base.eclass, in src_prepare. So EAPI has to be >>> at least 2 for this to be handled. However, I don't know why >>> base_src_prepare is not called and where to call it (well, I know that >>> it *could* be called at the end of kde_src_unpack, but I'm not sure if >>> it's correct and could break other packages). >>> >>> Regards Ladislav Laska >>> S pozdravem Ladislav Laska >>> --- >>> xmpp/jabber: ladislav.laska@××××××.cz >>> >>> >>> >>> On Thu, Feb 18, 2010 at 11:01 AM, Roman <lists@×××××××××.de> wrote: >>> >>> >>>> Hi, >>>> >>>> yes you are correct, adding >>>> src_unpack() { >>>>     kde-meta_src_unpack >>>>     epatch "${WORKDIR}/patches/kdepim-kresources-3.5_use-installed-kode.diff" >>>> } >>>> >>>> to the ebuild works, but since PATCHES is used by some more ebuilds i guess >>>> there should be a better solution integrating to eclass... >>>> >>>> Am Thursday 18 February 2010 02:44:26 schrieb Ladislav Laska: >>>> >>>> >>>>> You're right. I've looked into this earlier today and it is problem >>>>> fixed by that patch, which is correctly added to PATCHES environment >>>>> variable and should be applied by base eclass, but it's not (and I >>>>> don't know why) - I'll try to figure it out tomorrow. >>>>> >>>>> Regards Ladislav Laska >>>>> S pozdravem Ladislav Laska >>>>> --- >>>>> xmpp/jabber: ladislav.laska@××××××.cz >>>>> >>>>> On Thu, Feb 18, 2010 at 1:39 AM, Chris Bandy <cbandy@××××××.com> wrote: >>>>> >>>>> >>>>>> Chris Bandy wrote: >>>>>> >>>>>> >>>>>>> Chris Bandy wrote: >>>>>>> >>>>>>> >>>>>>>> Roman wrote: >>>>>>>> >>>>>>>> >>>>>>>>> Am Thursday 11 February 2010 10:56:29 schrieb Roman: >>>>>>>>> >>>>>>>>> >>>>>>>>>> hi, >>>>>>>>>> >>>>>>>>>> just tried a clean reinstall of kde3.5, but it looks like sth. >>>>>>>>>> changed again and kdepim-kresources won't install anymore. >>>>>>>>>> Since i am already leaving for the weekend, maybe so else could have >>>>>>>>>> a look at it? If not i will look into it next week... >>>>>>>>>> >>>>>>>>>> >>>>>>>>> Ok,  to f'up on myself... i tried looking into it, but looks like i >>>>>>>>> have not really an idea on how to fix it, it might be related to the >>>>>>>>> lates autotools update... >>>>>>>>> >>>>>>>>> greetings, >>>>>>>>> Roman >>>>>>>>> >>>>>>>>> >>>>>>>> I ran into this as well while moving from media-libs/jpeg-7 to 8.  I >>>>>>>> attach my info and build log after clearing ccache.  Can anyone shed >>>>>>>> some light? >>>>>>>> >>>>>>>> I haven't tried this[1] since the breakage does not look the same, but >>>>>>>> I may try it soon. >>>>>>>> >>>>>>>> [1] http://forums.gentoo.org/viewtopic-t-791293.html >>>>>>>> >>>>>>>> -- Chris >>>>>>>> >>>>>>>> >>>>>>> Yikes.  I'm glad my mail wasn't rejected!  If you'd like to keep your >>>>>>> inbox small, I've made pastes of my info[1] and build.log[2]. >>>>>>> >>>>>>> [1] http://bandy.pastebin.com/m78ae7eda >>>>>>> [2] http://bandy.pastebin.com/m560638ac  (359 kB) >>>>>>> >>>>>>> -- Chris >>>>>>> >>>>>>> >>>>>> It looks like this patch ( kdepim-kresources-3.5_use-installed-kode.diff >>>>>> ) is not getting applied, but this is as far as I can dig today. >>>>>> >>>>>> -- Chris >>>>>> >>>>>> >>>> Mit freundlichem Gruß, >>>> Roman v. Gemmeren >>>> >>>> -- >>>> The problem with any unwritten law is that you don't know where to go >>>> to erase it. >>>>                -- Glaser and Way >>>> >>>> >> >> base_src_prepare is not called because the directory already exists at >> line 149 of kde.eclass. I strongly suspect commit >> 9704c7d47bbf70ec8f3fd78fd3b00e7603dfa879 broke it. >> >> I have attached my build.log of "emerge --debug -1 >> kde-base/kdepim-kresources:3.5" The portion of interest starts around >> line 10574. >> >> I have also noticed that PATCHES were not applied for >> kde-base/kicker-3.5.10-r2, in case that helps.  Though I suspect no >> PATCHES are being applied when EAPI="1". >> >> -- Chris > > Reverting 9704c7d47bbf70ec8f3fd78fd3b00e7603dfa879 fixed both > kde-base/kdepim-kresources and kde-base/kicker for me. > > -- Chris > >

Replies

Subject Author
Re: [gentoo-desktop] kde-sunset: kdepim-kresources broken Martin von Gagern <Martin.vGagern@×××.net>
Re: [gentoo-desktop] kde-sunset: kdepim-kresources broken Ben de Groot <yngwin@g.o>