1 |
Yes, but that's not the problem. You see, the commit you're mentioning |
2 |
removes hack, but another hack is still present in kde-meta, which |
3 |
prevents prepare from base.eclass to be invoked (another "dummy" |
4 |
function). Removing this, only src_prepare in ebuild or in base.eclass |
5 |
can be invoked, both of them will do just fine. |
6 |
|
7 |
Unfortunately, src_prepare is eapi=2 thing, so we have to migrate all |
8 |
packages with patches to eapi 2, but this should not be a problem, |
9 |
since i've seen someone is already doing that. |
10 |
|
11 |
Anyway, I'll commit patch which will at least fix things for eapi 2. |
12 |
|
13 |
Regards Ladislav Laska |
14 |
S pozdravem Ladislav Laska |
15 |
--- |
16 |
xmpp/jabber: ladislav.laska@××××××.cz |
17 |
|
18 |
|
19 |
|
20 |
On Fri, Feb 19, 2010 at 8:26 AM, Chris Bandy <cbandy@××××××.com> wrote: |
21 |
> Chris Bandy wrote: |
22 |
>> Ladislav Laska wrote: |
23 |
>> |
24 |
>>> Some more info: |
25 |
>>> |
26 |
>>> PATCHES are handled in base.eclass, in src_prepare. So EAPI has to be |
27 |
>>> at least 2 for this to be handled. However, I don't know why |
28 |
>>> base_src_prepare is not called and where to call it (well, I know that |
29 |
>>> it *could* be called at the end of kde_src_unpack, but I'm not sure if |
30 |
>>> it's correct and could break other packages). |
31 |
>>> |
32 |
>>> Regards Ladislav Laska |
33 |
>>> S pozdravem Ladislav Laska |
34 |
>>> --- |
35 |
>>> xmpp/jabber: ladislav.laska@××××××.cz |
36 |
>>> |
37 |
>>> |
38 |
>>> |
39 |
>>> On Thu, Feb 18, 2010 at 11:01 AM, Roman <lists@×××××××××.de> wrote: |
40 |
>>> |
41 |
>>> |
42 |
>>>> Hi, |
43 |
>>>> |
44 |
>>>> yes you are correct, adding |
45 |
>>>> src_unpack() { |
46 |
>>>> kde-meta_src_unpack |
47 |
>>>> epatch "${WORKDIR}/patches/kdepim-kresources-3.5_use-installed-kode.diff" |
48 |
>>>> } |
49 |
>>>> |
50 |
>>>> to the ebuild works, but since PATCHES is used by some more ebuilds i guess |
51 |
>>>> there should be a better solution integrating to eclass... |
52 |
>>>> |
53 |
>>>> Am Thursday 18 February 2010 02:44:26 schrieb Ladislav Laska: |
54 |
>>>> |
55 |
>>>> |
56 |
>>>>> You're right. I've looked into this earlier today and it is problem |
57 |
>>>>> fixed by that patch, which is correctly added to PATCHES environment |
58 |
>>>>> variable and should be applied by base eclass, but it's not (and I |
59 |
>>>>> don't know why) - I'll try to figure it out tomorrow. |
60 |
>>>>> |
61 |
>>>>> Regards Ladislav Laska |
62 |
>>>>> S pozdravem Ladislav Laska |
63 |
>>>>> --- |
64 |
>>>>> xmpp/jabber: ladislav.laska@××××××.cz |
65 |
>>>>> |
66 |
>>>>> On Thu, Feb 18, 2010 at 1:39 AM, Chris Bandy <cbandy@××××××.com> wrote: |
67 |
>>>>> |
68 |
>>>>> |
69 |
>>>>>> Chris Bandy wrote: |
70 |
>>>>>> |
71 |
>>>>>> |
72 |
>>>>>>> Chris Bandy wrote: |
73 |
>>>>>>> |
74 |
>>>>>>> |
75 |
>>>>>>>> Roman wrote: |
76 |
>>>>>>>> |
77 |
>>>>>>>> |
78 |
>>>>>>>>> Am Thursday 11 February 2010 10:56:29 schrieb Roman: |
79 |
>>>>>>>>> |
80 |
>>>>>>>>> |
81 |
>>>>>>>>>> hi, |
82 |
>>>>>>>>>> |
83 |
>>>>>>>>>> just tried a clean reinstall of kde3.5, but it looks like sth. |
84 |
>>>>>>>>>> changed again and kdepim-kresources won't install anymore. |
85 |
>>>>>>>>>> Since i am already leaving for the weekend, maybe so else could have |
86 |
>>>>>>>>>> a look at it? If not i will look into it next week... |
87 |
>>>>>>>>>> |
88 |
>>>>>>>>>> |
89 |
>>>>>>>>> Ok, to f'up on myself... i tried looking into it, but looks like i |
90 |
>>>>>>>>> have not really an idea on how to fix it, it might be related to the |
91 |
>>>>>>>>> lates autotools update... |
92 |
>>>>>>>>> |
93 |
>>>>>>>>> greetings, |
94 |
>>>>>>>>> Roman |
95 |
>>>>>>>>> |
96 |
>>>>>>>>> |
97 |
>>>>>>>> I ran into this as well while moving from media-libs/jpeg-7 to 8. I |
98 |
>>>>>>>> attach my info and build log after clearing ccache. Can anyone shed |
99 |
>>>>>>>> some light? |
100 |
>>>>>>>> |
101 |
>>>>>>>> I haven't tried this[1] since the breakage does not look the same, but |
102 |
>>>>>>>> I may try it soon. |
103 |
>>>>>>>> |
104 |
>>>>>>>> [1] http://forums.gentoo.org/viewtopic-t-791293.html |
105 |
>>>>>>>> |
106 |
>>>>>>>> -- Chris |
107 |
>>>>>>>> |
108 |
>>>>>>>> |
109 |
>>>>>>> Yikes. I'm glad my mail wasn't rejected! If you'd like to keep your |
110 |
>>>>>>> inbox small, I've made pastes of my info[1] and build.log[2]. |
111 |
>>>>>>> |
112 |
>>>>>>> [1] http://bandy.pastebin.com/m78ae7eda |
113 |
>>>>>>> [2] http://bandy.pastebin.com/m560638ac (359 kB) |
114 |
>>>>>>> |
115 |
>>>>>>> -- Chris |
116 |
>>>>>>> |
117 |
>>>>>>> |
118 |
>>>>>> It looks like this patch ( kdepim-kresources-3.5_use-installed-kode.diff |
119 |
>>>>>> ) is not getting applied, but this is as far as I can dig today. |
120 |
>>>>>> |
121 |
>>>>>> -- Chris |
122 |
>>>>>> |
123 |
>>>>>> |
124 |
>>>> Mit freundlichem Gruß, |
125 |
>>>> Roman v. Gemmeren |
126 |
>>>> |
127 |
>>>> -- |
128 |
>>>> The problem with any unwritten law is that you don't know where to go |
129 |
>>>> to erase it. |
130 |
>>>> -- Glaser and Way |
131 |
>>>> |
132 |
>>>> |
133 |
>> |
134 |
>> base_src_prepare is not called because the directory already exists at |
135 |
>> line 149 of kde.eclass. I strongly suspect commit |
136 |
>> 9704c7d47bbf70ec8f3fd78fd3b00e7603dfa879 broke it. |
137 |
>> |
138 |
>> I have attached my build.log of "emerge --debug -1 |
139 |
>> kde-base/kdepim-kresources:3.5" The portion of interest starts around |
140 |
>> line 10574. |
141 |
>> |
142 |
>> I have also noticed that PATCHES were not applied for |
143 |
>> kde-base/kicker-3.5.10-r2, in case that helps. Though I suspect no |
144 |
>> PATCHES are being applied when EAPI="1". |
145 |
>> |
146 |
>> -- Chris |
147 |
> |
148 |
> Reverting 9704c7d47bbf70ec8f3fd78fd3b00e7603dfa879 fixed both |
149 |
> kde-base/kdepim-kresources and kde-base/kicker for me. |
150 |
> |
151 |
> -- Chris |
152 |
> |
153 |
> |