1 |
On Tue, Jan 4, 2022 at 3:03 PM Sam James <sam@g.o> wrote: |
2 |
> |
3 |
> |
4 |
> |
5 |
> On 4 Jan 2022, at 22:58, Sam James <sam@g.o> wrote: |
6 |
> |
7 |
> Crank down MAKEOPTS jobs if MAKEOPTS="-jN" is too high for the |
8 |
> amount of RAM available (uses amount declared as needed |
9 |
> in the ebuild). Typically should be ~2GB per job. |
10 |
> |
11 |
> Bug: https://bugs.gentoo.org/570534 |
12 |
> Signed-off-by: Sam James <sam@g.o> |
13 |
> --- |
14 |
> eclass/check-reqs.eclass | 42 +++++++++++++++++++++++++++++++++++++--- |
15 |
> 1 file changed, 39 insertions(+), 3 deletions(-) |
16 |
> |
17 |
> |
18 |
> Note that we discussed this on GitHub a bit when I just posted it there |
19 |
> for some rough feedback: https://github.com/gentoo/gentoo/pull/23311. |
20 |
> |
21 |
> I think this is valuable for reducing invalid bug reports from OOM and |
22 |
> easing user experience. |
23 |
> |
24 |
> Still kind of a WIP/rough draft, but may be ready in this state. Need |
25 |
> more testing, so not planning on pushing yet or anything. |
26 |
|
27 |
I'm still not sure I grasp why we cannot make OOMs easier to discover |
28 |
from portage. |
29 |
|
30 |
Most packages don't even use check-reqs, so your solution is very |
31 |
narrow (and I get why, because you get a lot of bug reports from the |
32 |
big packages that do use it.) |
33 |
|
34 |
Can we write a build log analyzer? |
35 |
|
36 |
-A |
37 |
|
38 |
PS: If this was a global change I'd downvote it. It's only for |
39 |
check-reqs though and most packages don't use check-reqs; I don't |
40 |
really care. I'd be concerned about adopting this kind of approach |
41 |
wider; its very much a bandaid. |