| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 04/12/2016 02:42 PM, Pacho Ramos wrote: |
| 5 |
> Hi! |
| 6 |
> |
| 7 |
> El lun, 11-04-2016 a las 22:04 -0400, NP-Hardass escribió: |
| 8 |
>> [...] # @FUNCTION: ematedocize # @DESCRIPTION: A wrapper around |
| 9 |
>> mate-doc-common ematedocize() { ebegin "Running mate-doc-common |
| 10 |
>> --copy" mate-doc-common --copy || die eend $? } |
| 11 |
>> |
| 12 |
> |
| 13 |
> Have you think in reporting this to autotools.eclass maintainers to |
| 14 |
> add the needed logic to autotools.eclass as done for all the other |
| 15 |
> stuff like gnome-doc, intltool... |
| 16 |
|
| 17 |
I hadn't, though, that would make things much easier I'll reach out |
| 18 |
to them and inquire. Thanks for the suggestion. |
| 19 |
|
| 20 |
> |
| 21 |
>> # @FUNCTION: mate_src_prepare # @DESCRIPTION: # Call |
| 22 |
>> gnome2_src_prepare to handle environment setup and patching, |
| 23 |
>> then # call eautoreconf if necessary mate_src_prepare() { |
| 24 |
>> debug-print-function ${FUNCNAME} "$@" |
| 25 |
>> |
| 26 |
>> local force_autoreconf=${FORCE_AUTORECONF:-false} [[ ${PV} == |
| 27 |
>> 9999 ]] && force_autoreconf=true |
| 28 |
>> |
| 29 |
>> gen_chksum() { find '(' -name 'Makefile.am' \ -o -name |
| 30 |
>> 'configure.ac' \ -o -name 'configure.in' ')' \ -exec cksum + | |
| 31 |
>> sort -k2 } |
| 32 |
>> |
| 33 |
>> local chksum=$(gen_chksum) |
| 34 |
>> |
| 35 |
>> gnome2_src_prepare |
| 36 |
>> |
| 37 |
>> if ${force_autoreconf} || [[ ${chksum} != $(gen_chksum) ]]; then |
| 38 |
>> eautoreconf ematedocize fi } |
| 39 |
>> |
| 40 |
> |
| 41 |
> I wonder if maybe this handling of "automatic eautoreconf" should |
| 42 |
> be moved to a more general eclass as there are some consumers that |
| 43 |
> are reimplementing this different times :/ |
| 44 |
> |
| 45 |
> In the past we could rely on autotools-utils.eclass for this, but |
| 46 |
> now, it looks like it needs to be redone in several other eclasses |
| 47 |
> (for example, xorg one) |
| 48 |
> |
| 49 |
> But it's only a question/opinion, I am not blocking your change or |
| 50 |
> similar ;) |
| 51 |
> |
| 52 |
|
| 53 |
I don't have my heart set in keeping it MATE specific. I just assumed |
| 54 |
that since the old eclass autotools-utils was banned without |
| 55 |
deprecation and had no successor that I was on my own. Moreover, |
| 56 |
since EAPI 6 forces eapply_user, we have no idea whether a user is |
| 57 |
going to choose to patch the autotools build system, requiring an |
| 58 |
eautoreconf, so, unfortunately, I think automatic detection of when to |
| 59 |
eautoreconf is a necessity. |
| 60 |
|
| 61 |
Does anyone else agree that this is a necessity for autotools based |
| 62 |
ebuilds in EAPI 6, and if so, any suggestions on were to put it so |
| 63 |
that it can be reused as much as possible? |
| 64 |
|
| 65 |
- -- |
| 66 |
NP-Hardass |
| 67 |
-----BEGIN PGP SIGNATURE----- |
| 68 |
Version: GnuPG v2 |
| 69 |
|
| 70 |
iQIcBAEBCAAGBQJXDVJiAAoJEBzZQR2yrxj7+XcQAIW54FgL3DMRxnjvOdaUJfT6 |
| 71 |
HSY0zFIX+Z9LXPRgpg8HS74pqs9E4KV8hjbAjlIF1Na3QBjfisViQzbyB6AIYhqg |
| 72 |
JjfJxgcCK/j0kDWx9AXZJIuBhmoKZMzklde0cqDpcAk2ugdq+AxUu+zvhn7tgbTP |
| 73 |
8CF1N1137NIvW0zSUuEima87r8oFWkgWXyGEy93O9++KM1t9QTStOdSb84tqfuhN |
| 74 |
iYgYe2qWVGfhYQ1InIQ9OJyazf+b112+WWuUfp9IpmhT5WeoFkXk8hfNE8dYl0G2 |
| 75 |
FnwiEYpAOMhiOeWrI0QkZ8lnwyunxmlfvmxTygtjK4a8c8HPC3sGmzwJ6Bo74kwk |
| 76 |
uLPVsh4ZcWmVnadgKJ/uI/NLc0BREqZQbOYaLDhgHYvoizzeXeisb0H8P6VmtOIN |
| 77 |
xI4HOFrfAn5biiBaQiVjilGJCByhMXpnJuINO+dA/ruCGyX/AEmhl+DrSxo27WmO |
| 78 |
1q4kO6vie8mqHvk8vvolnQLaULh9xMBsntCf6tzsTpv3Fnb4paeYr+aVOJVNbFxL |
| 79 |
hwzkQoV2OJg05uFRkRaq/q6rupbSNoia5+J54GOcwO0+nYxRpQCK/g+7wRdfRlFo |
| 80 |
9jmDztDOSqoPOzwnUnHUwPwFDWcCCG5vJYh3wqyW22UZSeEwPfIRxxwKNYf03nn/ |
| 81 |
SoGl+TI8E8PJHEP/BlYz |
| 82 |
=L6YE |
| 83 |
-----END PGP SIGNATURE----- |
Archives