Re: [gentoo-dev] profiles/arch/amd64/no-multilib cleanup WAS: [PATCH 1/8] profiles/hardened: Include base amd64-multilib profile in subprofile

[Michał Górny]

W dniu 02.03.2017, czw o godzinie 15∶09 +0100, użytkownik Michael
Haubenwallner napisał:
> On 01/21/2017 11:59 PM, Michał Górny wrote:
> > Include arch/amd64/no-multilib in the hardened no-multilib amd64
> > variant. Confirmed with profile-dumper that it does not currently change
> > anything.
> > ---
> >  profiles/hardened/linux/amd64/no-multilib/parent | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/profiles/hardened/linux/amd64/no-multilib/parent b/profiles/hardened/linux/amd64/no-multilib/parent
> > index 8305c3556463..0defac31415d 100644
> > --- a/profiles/hardened/linux/amd64/no-multilib/parent
> > +++ b/profiles/hardened/linux/amd64/no-multilib/parent
> > @@ -1,2 +1,3 @@
> > +../../../../arch/amd64/no-multilib
> >  ..
> >
>
> As hardened/linux/amd64 does inherit arch/amd64, this way arch/amd64
> always overrides arch/amd64/no-multilib, rendering the latter useless.
>
> Instead, profiles/hardened/linux/amd64/no-multilib/parent should read:
>  ..
>  ../../../../arch/amd64/no-multilib
>
> Beyond that:
> While arch/amd64/no-multilib of course _is_ an override to arch/amd64,
> question is whether it also should _perform_ the override by itself.
>
> Currently it does perform the override, causing lots of subsequent profiles
> to end up with arch/amd64 inherited multiple times - most prominent is the
> default/linux/amd64/13.0/no-multilib profile.
>
> So removing arch/amd64/no-multilib/parent would simplify things here.
>
> Thoughts?

I was considering that as well but I didn't really have time to look
into it properly. If it doesn't break anything, it's fine with me. You
may want to talk with arch team first, though.

-- 
Best regards,
Michał Górny