| 1 |
On 7/29/10 4:16 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
| 2 |
> |
| 3 |
> --- python.eclass |
| 4 |
> +++ python.eclass |
| 5 |
> @@ -355,6 +355,8 @@ |
| 6 |
> # Check if phase is pkg_setup(). |
| 7 |
> [[ "${EBUILD_PHASE}" != "setup" ]] && die "${FUNCNAME}() can be used only in pkg_setup() phase" |
| 8 |
> |
| 9 |
> + local locale |
| 10 |
> + |
| 11 |
> if [[ "$#" -ne 0 ]]; then |
| 12 |
> die "${FUNCNAME}() does not accept arguments" |
| 13 |
> fi |
| 14 |
> @@ -407,6 +409,16 @@ |
| 15 |
> unset -f python_pkg_setup_check_USE_flags |
| 16 |
> fi |
| 17 |
|
| 18 |
nit: Why not declare "local locale" here, close to its usage? |
| 19 |
|
| 20 |
> + locale="$(python -c 'import os; print(os.environ.get("LC_ALL", os.environ.get("LC_CTYPE", os.environ.get("LANG", "POSIX"))))')" |
| 21 |
> + if [[ "${locale}" != *.UTF-8 ]]; then |
| 22 |
> + eerror |
| 23 |
> + eerror "Currently used locale '${locale}' is unsupported and can cause build-time or run-time" |
| 24 |
> + eerror "problems (usually UnicodeDecodeErrors or UnicodeEncodeErrors). Bugs caused by this locale" |
| 25 |
> + eerror "will be closed as invalid. It is recommended to use a UTF-8 locale to avoid problems." |
| 26 |
> + eerror "See http://www.gentoo.org/doc/en/utf-8.xml for information on how to fix locale." |
| 27 |
> + eerror |
| 28 |
> + fi |
| 29 |
> + |
| 30 |
> PYTHON_PKG_SETUP_EXECUTED="1" |
| 31 |
> } |
| 32 |
> |
Archives