Gentoo Archives: gentoo-dev

From: "PaweĊ‚ Hajdan
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Locale check in python_pkg_setup()
Date: Thu, 29 Jul 2010 23:20:13
Message-Id: 4C520CB3.5000401@gentoo.org
In Reply to: [gentoo-dev] Locale check in python_pkg_setup() by Arfrever Frehtes Taifersar Arahesis
On 7/29/10 4:16 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > --- python.eclass > +++ python.eclass > @@ -355,6 +355,8 @@ > # Check if phase is pkg_setup(). > [[ "${EBUILD_PHASE}" != "setup" ]] && die "${FUNCNAME}() can be used only in pkg_setup() phase" > > + local locale > + > if [[ "$#" -ne 0 ]]; then > die "${FUNCNAME}() does not accept arguments" > fi > @@ -407,6 +409,16 @@ > unset -f python_pkg_setup_check_USE_flags > fi
nit: Why not declare "local locale" here, close to its usage?
> + locale="$(python -c 'import os; print(os.environ.get("LC_ALL", os.environ.get("LC_CTYPE", os.environ.get("LANG", "POSIX"))))')" > + if [[ "${locale}" != *.UTF-8 ]]; then > + eerror > + eerror "Currently used locale '${locale}' is unsupported and can cause build-time or run-time" > + eerror "problems (usually UnicodeDecodeErrors or UnicodeEncodeErrors). Bugs caused by this locale" > + eerror "will be closed as invalid. It is recommended to use a UTF-8 locale to avoid problems." > + eerror "See http://www.gentoo.org/doc/en/utf-8.xml for information on how to fix locale." > + eerror > + fi > + > PYTHON_PKG_SETUP_EXECUTED="1" > } >

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Locale check in python_pkg_setup() Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>