Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
Date: Thu, 12 Dec 2019 17:15:08
Message-Id: CAJ0EP40J-hL5SUBUh5eDsTqJh++16ZuXCWTXUy99er6j-xrh_Q@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default by NP-Hardass
1 On Thu, Dec 12, 2019 at 12:02 PM NP-Hardass <NP-Hardass@g.o> wrote:
2 >
3 > On 12/11/19 9:58 AM, Michał Górny wrote:
4 > > Append RESTRICT="!test? ( test )" in the default case when virtualx
5 > > is conditional to USE=test. This fixes 440 MissingTestRestrict
6 > > warnings.
7 > >
8 > > Signed-off-by: Michał Górny <mgorny@g.o>
9 > > ---
10 > > eclass/virtualx.eclass | 2 ++
11 > > 1 file changed, 2 insertions(+)
12 > >
13 > > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
14 > > index 40eeea5463bc..6aba6bf488dd 100644
15 > > --- a/eclass/virtualx.eclass
16 > > +++ b/eclass/virtualx.eclass
17 > > @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
18 > > fi
19 > > RDEPEND=""
20 > > IUSE="${VIRTUALX_REQUIRED}"
21 > > + [[ ${VIRTUALX_REQUIRED} == test ]] &&
22 > > + RESTRICT+=" !test? ( test )"
23 > > ;;
24 > > esac
25 > >
26 > >
27 >
28 > Is there a better way to address this than editing a ton of eclasses
29 > independently?
30
31 Not really.

Replies