Gentoo Archives: gentoo-dev

From: William Hubbs <williamh@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH v2 1/6] verify-sig.eclass: New eclass to verify OpenPGP sigs
Date: Tue, 06 Oct 2020 14:36:51
Message-Id: 20201006143644.GA20870@linux1.home
In Reply to: [gentoo-dev] [PATCH v2 1/6] verify-sig.eclass: New eclass to verify OpenPGP sigs by "Michał Górny"
1 Hey all,
2
3 I'm just picking an eclass to respond to because I see this pretty
4 often, so I'm definitely not picking on mgorny with this question.
5
6 On Tue, Oct 06, 2020 at 02:10:45PM +0200, Michał Górny wrote:
7
8 *snip*
9
10 > +case "${EAPI:-0}" in
11 > + 0|1|2|3|4|5|6)
12 > + die "Unsupported EAPI=${EAPI} (obsolete) for ${ECLASS}"
13 > + ;;
14 > + 7)
15 > + ;;
16 > + *)
17 > + die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
18 > + ;;
19 > +esac
20
21 Does it really matter that an EAPI is unsupported because it is obsolete
22 vs unknown? Can we simplify this case statement to the following or
23 something similar for all of our eclasses?
24
25 case "${EAPI:-0}" in
26 7)
27 ;;
28 *)
29 die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
30 ;;
31 esac
32
33 William

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies