Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] autotools-utils: drop base.eclass inherit and thus src_unpack() export.
Date: Wed, 30 Nov 2011 19:36:47
Message-Id: 201111301436.05001.vapier@gentoo.org
In Reply to: [gentoo-dev] [PATCH] autotools-utils: drop base.eclass inherit and thus src_unpack() export. by "Michał Górny"
1 On Wednesday 30 November 2011 13:23:53 Michał Górny wrote:
2 > +# @ECLASS-VARIABLE: DOCS
3 > +# @DESCRIPTION:
4 > +# Array containing documents passed to dodoc command.
5 > +#
6 > +# DOCS=( NEWS README )
7 > +
8 > +# @ECLASS-VARIABLE: HTML_DOCS
9 > +# @DESCRIPTION:
10 > +# Array containing documents passed to dohtml command.
11 > +#
12 > +# HTML_DOCS=( doc/html/ )
13
14 these examples give the illusion these are the defaults. might want to
15 clarify that ...
16
17 > +# @ECLASS-VARIABLE: PATCHES
18 > +# @DESCRIPTION:
19 > +# PATCHES array variable containing all various patches to be applied.
20 > +#
21 > +# PATCHES=( "${FILESDIR}/mypatch.patch" )
22
23 this one is obvious that there is no default. might want to subconsciously
24 encourage good practices in people and have the example read:
25 # PATCHES=( "${FILESDIR}/${P}-mypatch.patch" )
26 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies