| 1 |
On Thu, 22 Sep 2011 09:01:17 +0200 |
| 2 |
Ulrich Mueller <ulm@g.o> wrote: |
| 3 |
|
| 4 |
> > Attaching fixed version of the last two patches, and a complete |
| 5 |
> > eclass for convenience. |
| 6 |
> |
| 7 |
> Just a general comment: Is it really necessary to change all |
| 8 |
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure |
| 9 |
> [[ ${foo} ]] and [[ ! ${foo} ]]? |
| 10 |
> |
| 11 |
> The shortest possible form is not always the one that's best readable. |
| 12 |
|
| 13 |
The style change was approved by Donnie already. |
| 14 |
|
| 15 |
Also, this one looks better when a particular var is used as a 'bash |
| 16 |
boolean', e.g. EVCS_OFFLINE, bare, etc. Then [[ ${EVCS_OFFLINE} ]] is |
| 17 |
more explanatory than [[ -n ${EVCS_OFFLINE} ]]. |
| 18 |
|
| 19 |
-- |
| 20 |
Best regards, |
| 21 |
Michał Górny |
Archives