Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: ulm@g.o
Subject: Re: [gentoo-dev] git-2: a bunch of patches to review
Date: Thu, 22 Sep 2011 08:09:56
Message-Id: 20110922101119.391f4a01@pomiocik.lan
In Reply to: Re: [gentoo-dev] git-2: a bunch of patches to review by Ulrich Mueller
On Thu, 22 Sep 2011 09:01:17 +0200
Ulrich Mueller <ulm@g.o> wrote:

> > Attaching fixed version of the last two patches, and a complete > > eclass for convenience. > > Just a general comment: Is it really necessary to change all > [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure > [[ ${foo} ]] and [[ ! ${foo} ]]? > > The shortest possible form is not always the one that's best readable.
The style change was approved by Donnie already. Also, this one looks better when a particular var is used as a 'bash boolean', e.g. EVCS_OFFLINE, bare, etc. Then [[ ${EVCS_OFFLINE} ]] is more explanatory than [[ -n ${EVCS_OFFLINE} ]]. -- Best regards, Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] git-2: a bunch of patches to review "Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o>