| 1 |
On 12/04/2016 07:20 PM, Sam Jorna wrote: |
| 2 |
> On Sun, Dec 04, 2016 at 09:13:23PM -0600, A. Wilcox wrote: |
| 3 |
>> to read over it. (Would it be more desirable to have all changes in a |
| 4 |
>> single large commit, or one commit per package?) |
| 5 |
> |
| 6 |
> I'd think this is one of those cases best suited to a branch and merge |
| 7 |
> commit - best of both worlds. |
| 8 |
> |
| 9 |
> But that's just my two cents. :) |
| 10 |
> |
| 11 |
Yeah. Small, but numerous changes in many different locations aren't |
| 12 |
really suited to our usual one-commit-per-logical change bit. It might |
| 13 |
be better to branch off, run the sed call or whatever will be used to |
| 14 |
update the entire tree, then submit a PR. |
| 15 |
|
| 16 |
-- |
| 17 |
Daniel Campbell - Gentoo Developer |
| 18 |
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net |
| 19 |
fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 |
Archives