1 |
On Monday 07 of May 2012 10:32:45 Samuli Suominen wrote: |
2 |
> On 05/07/2012 02:24 AM, Ulrich Mueller wrote: |
3 |
> >>>> Therefore I suggest we move this example a bit down in skel.ebuild |
4 |
> >>>> as it's more logical to continue with new lines instead of applying |
5 |
> >>>> in-between |
6 |
> >>>> |
7 |
> >>>> Any objections? |
8 |
> >>> |
9 |
> >>> Yes. Please leave it as it is. |
10 |
> >> |
11 |
> >> Yeah, I will if someone has a (good) argument for doing so. |
12 |
> > |
13 |
> > RESTRICT and PROPERTIES are on a single line and it's natural to add |
14 |
> > them to the second group of such variables, namely LICENSE, SLOT, |
15 |
> > KEYWORDS, and IUSE. |
16 |
> > |
17 |
> > Whereas DEPEND and RDEPEND typically extend over several lines; |
18 |
> > sometimes they are quite long. So, a RESTRICT line placed after |
19 |
> > *DEPEND will be much more easily missed than in its current place. |
20 |
|
21 |
And I use quite different 'rule' where to place variables: |
22 |
- to separate frequently changed ones (KEYWORDS, IUSE) with rather invariant |
23 |
ones (SLOT, LICENSE) |
24 |
|
25 |
Rationale: |
26 |
It generates smaller diffs (and less conflicts when doing semi-automatic |
27 |
merges of ebuild changes between branches as those are likely both IUSE and |
28 |
KEYWORDS changes, KEYWORDS changes are rarely desired to be included in merge, |
29 |
if IUSE is just below the line with KEYWORDS, KEYWORD change will be |
30 |
accidentally taken in) |
31 |
|
32 |
-- |
33 |
regards |
34 |
MM |