Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev <gentoo-dev@l.g.o>
Cc: James Le Cuirot <chewi@g.o>
Subject: [gentoo-dev] [PATCH 10/14] cdrom.eclass: The CDROM_TOTAL_CDS variable is redundant now
Date: Mon, 17 Apr 2017 22:03:48
Message-Id: 20170417215359.30641-11-chewi@gentoo.org
In Reply to: [gentoo-dev] [PATCH] cdrom.eclass: Near rewrite by James Le Cuirot
1 This was never formally declared by the eclass or used by ebuilds.
2 ---
3 eclass/cdrom.eclass | 11 +++++------
4 1 file changed, 5 insertions(+), 6 deletions(-)
5
6 diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
7 index 10a19551161a..95bf48829e14 100644
8 --- a/eclass/cdrom.eclass
9 +++ b/eclass/cdrom.eclass
10 @@ -52,7 +52,6 @@ cdrom_get_cds() {
11 # the # of files they gave us
12 local cdcnt=0
13 local f=
14 - export CDROM_TOTAL_CDS=${cdcnt}
15 export CDROM_CURRENT_CD=1 CDROM_CHECKS=( "${@}" )
16
17 # now we see if the user gave use CD_ROOT ...
18 @@ -60,7 +59,7 @@ cdrom_get_cds() {
19 if [[ -n ${CD_ROOT}${CD_ROOT_1} ]] ; then
20 local var=
21 cdcnt=0
22 - while [[ ${cdcnt} -lt ${CDROM_TOTAL_CDS} ]] ; do
23 + while [[ ${cdcnt} -lt ${#} ]] ; do
24 ((++cdcnt))
25 var="CD_ROOT_${cdcnt}"
26 [[ -z ${!var} ]] && var="CD_ROOT"
27 @@ -68,7 +67,7 @@ cdrom_get_cds() {
28 eerror "You must either use just the CD_ROOT"
29 eerror "or specify ALL the CD_ROOT_X variables."
30 eerror "In this case, you will need" \
31 - "${CDROM_TOTAL_CDS} CD_ROOT_X variables."
32 + "${#} CD_ROOT_X variables."
33 die "could not locate CD_ROOT_${cdcnt}"
34 fi
35 done
36 @@ -86,7 +85,7 @@ cdrom_get_cds() {
37
38 # User didn't help us out so lets make sure they know they can
39 # simplify the whole process ...
40 - if [[ ${CDROM_TOTAL_CDS} -eq 1 ]] ; then
41 + if [[ ${#} -eq 1 ]] ; then
42 einfo "This ebuild will need the ${CDROM_NAME:-cdrom for ${PN}}"
43 echo
44 einfo "If you do not have the CD, but have the data files"
45 @@ -99,7 +98,7 @@ cdrom_get_cds() {
46 echo
47 else
48 _cdrom_set_names
49 - einfo "This package may need access to ${CDROM_TOTAL_CDS} cds."
50 + einfo "This package may need access to ${#} cds."
51 local cdcnt
52 for cdcnt in $(seq ${#}); do
53 local var=CDROM_NAME_${cdcnt}
54 @@ -189,7 +188,7 @@ _cdrom_locate_file_on_cd() {
55
56 echo
57 if [[ ${showedmsg} -eq 0 ]] ; then
58 - if [[ ${CDROM_TOTAL_CDS} -eq 1 ]] ; then
59 + if [[ ${#CDROM_CHECKS[@]} -eq 1 ]] ; then
60 if [[ -z ${CDROM_NAME} ]] ; then
61 einfo "Please insert+mount the cdrom for ${PN} now !"
62 else
63 --
64 2.11.0