Gentoo Archives: gentoo-dev

From: Ionen Wolkens <ionen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes
Date: Tue, 31 May 2022 14:29:51
Message-Id: YpYmVjyuJdhGlWVI@eversor
In Reply to: Re: [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes by Anna
1 On Tue, May 31, 2022 at 06:54:21PM +0500, Anna wrote:
2 > On 2022-05-31 07:23, Ionen Wolkens wrote:
3 > > Implementation / available wrappers / usefulness still up for debate,
4 > > but without further comments I consider this ready (albeit first time
5 > > touching / making an eclass, so I could be overlooking simple things).
6 > > Also partly uses >=bash-4.4, so EAPI-7 is not considered.
7 >
8 > From ebuild(5):
9 > > Beginning with EAPI 4, the dosed helper no longer exists
10 > > Ebuilds should call sed(1) directly (and assume that it is GNU
11 > > sed).
12 >
13 > What were the reasons to remove this helper? Do they still apply to esed
14 > as an eclass?
15
16 Haven't looked up exact history, but afaik dosed existed because of sed
17 formerly not having -i. And editing files in-place was tedious in
18 ebuilds with cp/mv. With -i becoming commonplace (PMS also requires
19 GNU sed) it lost its purpose beside just allowing to skip -i/||die.
20
21 esed does bring back the -i/die skipping but that's not its inherent
22 purpose and GNU sed currently does not support a mean to report if
23 changes occurred (if this happens, esed may well become obsolete too).
24
25 --
26 ionen

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies