| 1 |
Dnia 2015-10-10, o godz. 18:50:51 |
| 2 |
"Brian Dolbec" <dolsen@g.o> napisał(a): |
| 3 |
|
| 4 |
> commit: 6d6b97e870f98e26a6e5de0712da048495057286 |
| 5 |
> Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org> |
| 6 |
> AuthorDate: Sat Oct 10 17:47:28 2015 +0000 |
| 7 |
> Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org> |
| 8 |
> CommitDate: Sat Oct 10 18:49:55 2015 +0000 |
| 9 |
> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d6b97e8 |
| 10 |
|
| 11 |
(taking this as an example of common mistake, please don't take it |
| 12 |
personally) |
| 13 |
|
| 14 |
> sys-apps/portage: Add py3.5 compatibility to 2.2.23 and 9999. |
| 15 |
> |
| 16 |
> Clean out older versions. |
| 17 |
> Keep 2.2.8-r2 for python-2.6/3.2 upgrade compatibility. |
| 18 |
|
| 19 |
The commit message does not follow the standard guidelines for git |
| 20 |
commit messages. The summary line should describe the change shortly, |
| 21 |
and the body should expand on it. In your case, the summary line |
| 22 |
describes part of the change and the body part another change. |
| 23 |
|
| 24 |
As a result, a user looking at --oneline logs would see that you only |
| 25 |
added py3.5 compatibility while you also removed ebuilds. |
| 26 |
|
| 27 |
Furthermore, *please* don't mix old version removals with other |
| 28 |
changes. This makes it unnecessarily hard to revert breaking changes. |
| 29 |
Let's suppose you accidentally removed a version that had reverse |
| 30 |
dependencies. If you did it in a separate commit, we could quickly |
| 31 |
revert that commit and save users from seeing the breakage, and we |
| 32 |
could do the removal properly afterwards. When changes are mixed like |
| 33 |
this, you have to do partial reverts and partial re-commits, and things |
| 34 |
get unnecessarily hard. |
| 35 |
|
| 36 |
> Package-Manager: portage-2.2.23 |
| 37 |
> |
| 38 |
> sys-apps/portage/Manifest | 4 - |
| 39 |
> sys-apps/portage/portage-2.2.14.ebuild | 352 ------------------------------- |
| 40 |
> sys-apps/portage/portage-2.2.18.ebuild | 352 ------------------------------- |
| 41 |
> sys-apps/portage/portage-2.2.20.ebuild | 365 --------------------------------- |
| 42 |
> sys-apps/portage/portage-2.2.22.ebuild | 363 -------------------------------- |
| 43 |
> sys-apps/portage/portage-2.2.23.ebuild | 2 +- |
| 44 |
> sys-apps/portage/portage-9999.ebuild | 2 +- |
| 45 |
> 7 files changed, 2 insertions(+), 1438 deletions(-) |
| 46 |
|
| 47 |
-- |
| 48 |
Best regards, |
| 49 |
Michał Górny |
| 50 |
<http://dev.gentoo.org/~mgorny/> |
Archives