| 1 |
On Sun, 26 Feb 2017 22:07:48 +0100 Ulrich Mueller wrote: |
| 2 |
|
| 3 |
>>>>>> On Sun, 26 Feb 2017, Robin H Johnson wrote: |
| 4 |
> |
| 5 |
>> The 2014-10-14 meeting did NOT specify what CVS headers were in |
| 6 |
>> question, and it was later decided that this was $Header$, not |
| 7 |
>> $Id$. |
| 8 |
> |
| 9 |
>When and by whom was that decided? The unanimous council decision was |
| 10 |
>to remove "CVS headers" and the obvious understanding is that this |
| 11 |
>includes all Header, Id, Date, and so on. Quoting the actual agenda |
| 12 |
>item (which was submitted by another infra member, BTW): |
| 13 |
> |
| 14 |
># 3. CVS Headers |
| 15 |
># |
| 16 |
># The hateful thing. We could supposedly somehow fill them in rsync |
| 17 |
># but that's complex and very dangerous (think of all the broken patch |
| 18 |
># files currently in gx86). I think we should kill them. |
| 19 |
># |
| 20 |
># And while at it, I think it'd be good to actually remove most of |
| 21 |
># them from our files -- changing header templates and so on. While |
| 22 |
># not strictly useful, it decreases the size of the repo a bit and |
| 23 |
># avoids any future nightmares :). |
| 24 |
> |
| 25 |
>Then in the summary of the 2016-11-13 council meeting we have this: |
| 26 |
> |
| 27 |
>- Bug 579460 "please make repoman ignore a missing "# $Id$" header |
| 28 |
>line": |
| 29 |
> Implemented in repoman-2.3.0, but not yet in stable. Once this is |
| 30 |
> done, CVS headers can be removed as per 2014-10-14 council decision. |
| 31 |
> |
| 32 |
>Note that it explicitly mentions $Id$, and until today nobody had |
| 33 |
>raised any objections against its revoval. |
| 34 |
|
| 35 |
Well, here is my objection now. And it seems like nobody at the |
| 36 |
council seems to have understood the intention of this $Id$ header in |
| 37 |
git. |
| 38 |
See https://git-scm.com/docs/gitattributes and search for "ident". |
| 39 |
|
| 40 |
>> This was also discussed in August 2015: |
| 41 |
>> Subject: 'Infra plans regarding $Id$ - official answer...' |
| 42 |
>> https://archives.gentoo.org/gentoo-dev/message/d01ce943a9f9404c454c26bdb7efdf0e |
| 43 |
> |
| 44 |
>> $Id$ is used by Git as well, and I was a strong advocate that |
| 45 |
>> expansion of $Id$ should be ENABLED in the rsync exports, because it |
| 46 |
>> allowed tracing what version of a file was actually in use. |
| 47 |
> |
| 48 |
>I don't see any expansion of $Id$ in rsync as of today, 18 months |
| 49 |
>after the Git conversion. If it wasn't missed for 18 months, one can |
| 50 |
>hardly claim that it would be an important feature. |
| 51 |
> |
| 52 |
>Also I suspect that it is too late to enable it now, because it will |
| 53 |
>potentially break patches that have been added after the conversion to |
| 54 |
>Git. |
| 55 |
|
| 56 |
There is no need to enable it by default. But it is a very nice way to |
| 57 |
verify ebuild changes if being enabled locally on a git clone of the |
| 58 |
tree. Ever since portage was migrated to git I had this line in |
| 59 |
my .git/info/attributes file on my dev box: |
| 60 |
|
| 61 |
*.ebuild ident |
| 62 |
|
| 63 |
This is a very useful feature and should not be removed only because |
| 64 |
council was told that it's a mere CVS migration cruft. It is not! |
| 65 |
|
| 66 |
-- |
| 67 |
Lars Wendler |
| 68 |
Gentoo package maintainer |
| 69 |
GPG: 21CC CF02 4586 0A07 ED93 9F68 498F E765 960E 9B39 |
| 70 |
|
| 71 |
Attention! New gpg key! See |
| 72 |
https://www.gentoofan.org/blog/index.php?/archives/9-New-gpg-keys.html |
Archives