1 |
Ryan Hill posted on Wed, 25 Apr 2012 22:44:33 -0600 as excerpted: |
2 |
|
3 |
> On Wed, 18 Apr 2012 22:41:39 +0100 David Leverton |
4 |
> <levertond@××××××××××.com> wrote: |
5 |
> |
6 |
>> The point I was trying to get at was that it seems a bit heavyweight to |
7 |
>> rely on a whole eclass for a minor use-case, as well as a bit |
8 |
>> error-prone to expect people to remember it every time, but maybe |
9 |
>> that's the least bad option after all.... |
10 |
> |
11 |
> Yeah the whole idea here was to make user patches available without |
12 |
> ebuild modifications or eclass dependence. |
13 |
|
14 |
Being a user of this functionality since <name forgotten, unfortunately> |
15 |
first introduced it with his bashrc hooks and the additional |
16 |
FEATURES=userpatch he used, and currently using a nasty hack to ensure |
17 |
that it gets run for every package, even those not calling base.eclass... |
18 |
|
19 |
IMO we're over-thinking this. Keep in mind that while being able to |
20 |
simply drop a patch in /etc/portage/patches/cat/pkg/ is very useful |
21 |
indeed, ultimately, all it does is eliminate the necessity of manually |
22 |
copying the ebuild to a personal overlay and setting up the patch to be |
23 |
applied via the ebuild itself. |
24 |
|
25 |
My suggestion is therefore to do the simple thing, just apply any patches |
26 |
found in the patches dir, and punt on the complicated do-we-eautoreconf- |
27 |
or-not thing. |
28 |
|
29 |
Just having the patches applied consistently will be a HUGE improvement |
30 |
from what we have at the moment, and it doesn't prevent people from |
31 |
falling back to the old copy-ebuild-to-overlay-and-modify method, should |
32 |
anything "fancy", including eautoreconf, but of course also including all |
33 |
the other things people modify ebuilds for OTHER than "simple patching", |
34 |
be needed. |
35 |
|
36 |
IOW, let's quit letting the perfect be the enemy of the good, and just |
37 |
get on with it, already. I know from experience that this eliminates a |
38 |
good 80-90% of what would otherwise be personal overlay ebuilds, here, |
39 |
and it's not as if it's an EITHER overlay OR patches dir thing, so let's |
40 |
"just do it", and people who need anything fancier can still do the |
41 |
overlay thing they're doing now, while those just applying a simple patch |
42 |
no longer have to worry about whether dropping it in patches is enough or |
43 |
not. |
44 |
|
45 |
-- |
46 |
Duncan - List replies preferred. No HTML msgs. |
47 |
"Every nonfree program has a lord, a master -- |
48 |
and if you use the program, he is your master." Richard Stallman |