Archives
Archives
| From: | "Chí-Thanh Christopher Nguyễn" <chithanh@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | ||
| Date: | Sat, 23 Jul 2016 22:17:33 | ||
| Message-Id: | 5793ECF1.7090204@gentoo.org | ||
| In Reply to: | [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts by "Michał Górny" |
||
| 1 | Michał Górny schrieb: |
| 2 | > Ensure that proper number of parameters is passed to each versionator |
| 3 | > function; die otherwise. This prevents the functions from proceeding |
| 4 | > with undefined behavior when mis-called. |
| 5 | |
| 6 | You are making what versionator.eclass accepts stricter. That it used to work |
| 7 | when passed multiple versions may be unintentional, but I think you need to |
| 8 | introduce a new eclass or new function names in this case. |
| 9 | |
| 10 | |
| 11 | Best regards, |
| 12 | Chí-Thanh Christopher Nguyễn |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | "Michał Górny" <mgorny@g.o> |