Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o, toolchain@g.o
Subject: Re: [gentoo-dev] Re: [PATCH 4/4] toolchain-funcs.eclass: Add helpful tc-is-{gcc,clang} wrappers
Date: Fri, 24 Jun 2016 07:48:45
Message-Id: 20160624074833.GE24532@vapier.lan
In Reply to: Re: [gentoo-dev] Re: [PATCH 4/4] toolchain-funcs.eclass: Add helpful tc-is-{gcc,clang} wrappers by "Michał Górny"
1 On 24 Jun 2016 07:40, Michał Górny wrote:
2 > On Thu, 23 Jun 2016 21:32:34 -0400 Mike Frysinger wrote:
3 > > On 22 Jun 2016 22:06, Michał Górny wrote:
4 > > > +# @FUNCTION: tc-is-gcc
5 > > > +# @DESCRIPTION:
6 > > > +# Return true if the current compiler is pure GCC.
7 > >
8 > > "pure" doesn't make much sense and is just confusing
9 > >
10 > > shouldn't this be a @RETURN instead of @DESCRIPTION ? same for clang below.
11 >
12 > I've followed suit with other functions in the eclass. They use @RETURN
13 > for stuff that is echoed, and @DESCRIPTION for exit codes.
14
15 right ... bash doesn't allow you to @RETURN a string
16 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature