Re: [gentoo-dev] Using default src_compile() in ebuilds

[Ryan Shaw]

Arcady wrote:

> Someone submitted an ebuild that does not define src_compile()
> explicitely.  The ebuild seems to work fine, but I am not sure whether
> this is acceptable.  My main concern is whether the default
> src_compile() will abort merging a package if configuration or
> compilation step fails.

actually, it won't fail. but i think this a bug in ebuild.sh.
the default src_compile() returns 1 if it fails:

src_compile() { 
        if [ -x ./configure ] ; then
	        econf || return 1
		emake || return 1
	fi
	return 
}

but dyn_compile() is not checking the return value. i think
it should. until this is fixed, though, it is probably better
not to use the default src_compile().

> Personally, I'd prefer an explicit src_compile in every ebuild, but I
> can also see the benefits of reusing code from the default one.

i think it would be nice to reuse the default one if possible.
but if you disagree, then i think the default src_compile() should
be changed to do nothing, otherwise the implication is that people 
should use it.

ryan