Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: prefix@g.o, toolchain@g.o, Sam James <sam@g.o>, "Aaron W . Swenson" <titanofold@g.o>
Subject: [gentoo-dev] [PATCH 1/2] prefix.eclass: don't redundantly define EPREFIX as an eclass variable
Date: Sun, 14 Aug 2022 17:58:23
Message-Id: 20220814175807.1984711-1-sam@gentoo.org
1 Since EAPI 3, EPREFIX has been defined via PMS. Having this as an
2 "eclass variable" in docs is confusing as it implies one needs
3 prefix.eclass to provide it.
4
5 Drop it given it adds nothing and causes confusion.
6
7 Reported-by: Aaron W. Swenson <titanofold@g.o>
8 Signed-off-by: Sam James <sam@g.o>
9 ---
10 eclass/prefix.eclass | 14 +-------------
11 1 file changed, 1 insertion(+), 13 deletions(-)
12
13 diff --git a/eclass/prefix.eclass b/eclass/prefix.eclass
14 index 8d50d0ba7b6e..4a8c0e4ff15f 100644
15 --- a/eclass/prefix.eclass
16 +++ b/eclass/prefix.eclass
17 @@ -1,4 +1,4 @@
18 -# Copyright 1999-2021 Gentoo Authors
19 +# Copyright 1999-2022 Gentoo Authors
20 # Distributed under the terms of the GNU General Public License v2
21
22 # @ECLASS: prefix.eclass
23 @@ -20,18 +20,6 @@ esac
24 if [[ -z ${_PREFIX_ECLASS} ]]; then
25 _PREFIX_ECLASS=1
26
27 -# @ECLASS_VARIABLE: EPREFIX
28 -# @DESCRIPTION:
29 -# The offset prefix of a Gentoo Prefix installation. When Gentoo Prefix
30 -# is not used, ${EPREFIX} should be "". Prefix Portage sets EPREFIX,
31 -# hence this eclass has nothing to do here in that case.
32 -# Note that setting EPREFIX in the environment with Prefix Portage sets
33 -# Portage into cross-prefix mode.
34 -if [[ ! ${EPREFIX+set} ]]; then
35 - export EPREFIX=''
36 -fi
37 -
38 -
39 # @FUNCTION: eprefixify
40 # @USAGE: <list of to be eprefixified files>
41 # @DESCRIPTION:
42 --
43 2.37.2

Replies