Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev <gentoo-dev@l.g.o>
Cc: James Le Cuirot <chewi@g.o>
Subject: [gentoo-dev] [PATCH 06/14] cdrom.eclass: Simplify loop with seq
Date: Mon, 17 Apr 2017 22:01:10
Message-Id: 20170417215359.30641-7-chewi@gentoo.org
In Reply to: [gentoo-dev] [PATCH] cdrom.eclass: Near rewrite by James Le Cuirot
1 ---
2 eclass/cdrom.eclass | 7 +++----
3 1 file changed, 3 insertions(+), 4 deletions(-)
4
5 diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
6 index 681683f9328c..b8fdb03ac535 100644
7 --- a/eclass/cdrom.eclass
8 +++ b/eclass/cdrom.eclass
9 @@ -104,10 +104,9 @@ cdrom_get_cds() {
10 else
11 _cdrom_set_names
12 einfo "This package will need access to ${CDROM_TOTAL_CDS} cds."
13 - cdcnt=0
14 - while [[ ${cdcnt} -lt ${CDROM_TOTAL_CDS} ]] ; do
15 - ((++cdcnt))
16 - var="CDROM_NAME_${cdcnt}"
17 + local cdcnt
18 + for cdcnt in $(seq ${#}); do
19 + local var=CDROM_NAME_${cdcnt}
20 [[ ! -z ${!var} ]] && einfo " CD ${cdcnt}: ${!var}"
21 done
22 echo
23 --
24 2.11.0