Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: tove@g.o, grobian@g.o
Subject: Re: [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog
Date: Tue, 07 Aug 2012 16:24:15
Message-Id: 20120807182354.2e863145@pomiocik.lan
In Reply to: [gentoo-dev] Re: gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog by Torsten Veller
1 On Tue, 7 Aug 2012 18:03:14 +0200
2 Torsten Veller <tove@g.o> wrote:
3
4 > * "Fabian Groffen (grobian)" <grobian@g.o>:
5 > > grobian 12/08/07 15:21:54
6 > >
7 > > Modified: ChangeLog
8 > > Added: XML-Parser-2.410.0-r1.ebuild
9 > > Log:
10 > > Fix expat detection for FreeBSD that silently went unnoticed.
11 >
12 > The following single quotes were dropped:
13 >
14 > -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)'
15 > EXPATINCPATH='${EPREFIX}/usr/include'"
16 > +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
17 > EXPATINCPATH=${EPREFIX}/usr/include"
18 >
19 > Sorry, I don't understand the problem. Is it a general problem with
20 > the single quote or a special FreeBSD problem?
21
22 A general problem. It won't work unless it's eval-ed. And if it were,
23 there will be more harm than you can possibly imagine.
24
25 > I think we should convert all myconf strings to arrays:
26 > myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir)
27 > EXPATINCPATH="${EPREFIX}"/usr/include )
28
29 +1.
30
31 --
32 Best regards,
33 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies