| 1 |
2010-07-05 20:00:11 Mark Loeser napisał(a): |
| 2 |
> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: |
| 3 |
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a): |
| 4 |
> > > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
| 5 |
> > > > 2010-07-05 18:13:26 Samuli Suominen napisał(a): |
| 6 |
> > > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
| 7 |
> > > >>> These minor changes in python.eclass and distutils.eclass have been already |
| 8 |
> > > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar |
| 9 |
> > > >>> with internals of current code before trying to understand these minor changes. |
| 10 |
> > > >>> Suggestions about indentation and quoting will be rejected. |
| 11 |
> > > >>> |
| 12 |
> > > >> |
| 13 |
> > > >> You have been already told to get rid of all the color customizations in |
| 14 |
> > > >> the python eclasses here: |
| 15 |
> > > >> |
| 16 |
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 |
| 17 |
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 |
| 18 |
> > > >> |
| 19 |
> > > >> [ .. ] |
| 20 |
> > > >> |
| 21 |
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
| 22 |
> > > >> |
| 23 |
> > > >> The bug was wrongly closed as fixed, as it's not really fixed before |
| 24 |
> > > >> it's all punted |
| 25 |
> > > > |
| 26 |
> > > > Colors can be used with echo. |
| 27 |
> > > > |
| 28 |
> > > |
| 29 |
> > > Stop using echo for output and switch to standard output functions, like |
| 30 |
> > > einfo/eerror/elog/... like told in |
| 31 |
> > > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
| 32 |
> > |
| 33 |
> > You should read relevant part of comment #7: |
| 34 |
> > "The colors can of course be continued to be used in outputs that are purely build |
| 35 |
> > time outputting and not for communicating things for users like what cmake builds do." |
| 36 |
> > |
| 37 |
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users. |
| 38 |
> |
| 39 |
> Everyone else has already made valid points. I'm just picking this one |
| 40 |
> to reply to now. Please remove the colors you have added. If you need |
| 41 |
> a new function, say "eqawarn", we should have that added in the next |
| 42 |
> EAPI with a description of when and where to use it. |
| 43 |
|
| 44 |
In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used, |
| 45 |
then its output wouldn't be logged by Portage. |
| 46 |
|
| 47 |
-- |
| 48 |
Arfrever Frehtes Taifersar Arahesis |
Archives