Gentoo Archives: gentoo-dev

From: James Cloos <cloos@×××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2.eclass review phase one
Date: Sun, 06 Feb 2011 16:55:58
Message-Id: m3lj1tumtb.fsf@jhcloos.com
In Reply to: [gentoo-dev] git-2.eclass review phase one by "Tomáš Chvátal"
1 > # we can not jump between using and not using SUBMODULES so we need to
2 > # refetch the source when needed
3
4 In that section, please do not rm(1) the existing clone; move it out of
5 the way just like portage does when checksums fail.
6
7 Nothing under DISTDIR should /ever/ be subject to behind-the-back deletion.
8
9 Also, and if I read that right, you use clone to copy the src for
10 building only when EGIT_HAS_SUBMODULES is true, yes? Please use clone
11 for the other case, too. Letting the package's build system know that
12 it is building directly from a the repo is a /good thing/.
13
14 -JimC
15 --
16 James Cloos <cloos@×××××××.com> OpenPGP: 1024D/ED7DAEA6